Introduce resource preparation - #250
Open
jeipollack wants to merge 1 commit into
Open
Conversation
- Add RESOURCE_PREPARERS registry for resource preparation callables - Add prepare_resources helper to invoke resource preparers with configuration - Add/update unit tests for resource preparation and resource resolution - Extend RESOURCES_DEFAULT in conftest.py to support resource preparation tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce resource preparation as part of resource resolution, allowing missing required resources to be prepared through registered resource preparers.
Closes #249
What’s changed
RESOURCE_PREPARERSregistry for resource preparation callablesprepare_resourceshelper to invoke resource preparers with resource configuration and datasetresolve()to prepare missing resources and combine them with caller-provided resourcesRESOURCES_DEFAULTinconftest.pyto support resource preparation testsHow to test / verify
resources_test.pyScope
Changelog
Reviewer Checklist
develop, ormainfor release PRs)ruff)Next Steps / Notes (if applicable)
The resource-preparation mechanism currently provides the orchestration layer through
RESOURCE_PREPARERS, but concrete resource preparers still need to be implemented.In particular, a callable for preparing
psf_models(e.g. through the PSF inference pipeline) will be added in a follow-up PR once the appropriate inference API has been defined.