Observe a pull request's base branch instead of assuming stable - #849
Merged
Conversation
crypter-review reviewed every pull request against stable. A release pull request targets main, so the diff it handed the lenses was stable against itself: empty. Four lenses read nothing and reported nothing wrong, which is indistinguishable from a clean review. The skill now takes the base branch from the pull request and passes it down, and crypter-workspace takes it as --base, defaulting to stable for work built here. A base that does not resolve is caught before the clone, so a corrected retry is not refused by the half-built workspace of the failed one. The workspace's second name for the org repository goes with it. A clone maps the source's local branches into origin/*, which is what upstream/stable existed to work around; pointing remote.origin.fetch at the host's remote-tracking refs gets the same guarantee under one name, and keeps it against a later bare fetch. Co-authored-by: n <e@f> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypter-reviewassumed every pull request targetsstable. A release pull request targetsmain, so the lenses were handedstablediffed against itself — an empty diff, which reads as four lenses finding nothing wrong. The skill now takes the base branch from the pull request and passes it through the examine skill to thereviewerandconformance-auditoragents, which take it as an argument.crypter-workspace creategains--base {branch}, defaulting tostable. It resolves the base before cloning, so a base that does not exist leaves nothing behind for a corrected retry to trip over.The workspace's
upstream/stableis gone. A clone maps the source's local branches intoorigin/*, which is what that second name existed to work around;remote.origin.fetchnow points at the host's remote-tracking refs, soorigin/{branch}means the same thing on both sides and stays that way after a baregit fetch./crypter-devcontainer-examinetakes a required base ref between the ref and the optional plan path — a signature change for anything invoking it directly.crypter-changeandcrypter-devcontainer-implementare unchanged in behaviour.crypter-triage-reviewstill takes the default. Its verify path reads the worktree rather than diffing a base, so nothing there depends on it.