Split the reviewer conventions across the lenses that own them - #850
Merged
Conversation
Every lens was handed the same list of Crypter conventions while also being told to stay inside its lens, so the security lens was primed to report a missing Async suffix and forbidden from reporting it in the same breath. Which way a reviewer resolved that was left to chance. The conventions are now split by what goes wrong when they are broken, and each half lives in the lens brief that can judge the consequence: monads, sync IO, constructors, enums and missing migrations under correctness; history-narrating comments and Async naming under maintainability; validated primitives under security. Testability claims none, rather than being given one to justify the symmetry. That moves them out of the shared agent definition and into the prompt, where the skill already said the lens belongs. The briefs must now be passed in full for the conventions to be reviewed at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
revieweragent gave every lens the same list of Crypter conventions while also telling it to stay inside its lens. The security lens was primed to report a missingAsyncsuffix and forbidden from reporting it at the same time, and nothing decided which instruction won.The conventions are now split by what goes wrong when they are broken, and each part sits in the lens brief that can judge that consequence: monads, sync IO, constructors, enums and missing migrations under correctness; history-narrating comments and
Asyncnaming under maintainability; validated primitives under security. Testability claims none.The list moves out of
.claude/agents/reviewer.mdand into the lens briefs incrypter-devcontainer-examine, so the agent definition stays lens-agnostic. The lens table became four prose briefs because the conventions do not fit in a table cell.Worth knowing: the briefs now have to reach each reviewer in full. A caller that paraphrases one drops the conventions under it silently.