Move the unit tests into a tests/ directory - #37
Merged
Conversation
The test modules sat in scripts/ alongside skill_eval.py, the LLM eval harness, which is the only thing left in there that is genuinely a script. Discovery had to be pointed at a directory whose contents were two unrelated kinds of file, and every test module's own name suggested scripts/ was where new tests belonged. They are now tests/, and `make test` -- the target CI runs -- discovers from there. Each module already computed the repo root as its parent directory and imported the package normally, so the move is the rename plus the path in the "Run:" line of each docstring. skill_eval.py stays behind; the Makefile mounts it into the container by path.
The README and the contributor notes both described the unit suite as `scripts/test_*.py` and gave the discovery command against scripts/, and two module docstrings named the test file that pins their behavior by its old path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit test modules sat in
scripts/next toskill_eval.py, the LLM eval harness — the only thing left in there that is genuinely a script. Discovery had to be pointed at a directory holding two unrelated kinds of file, and every test module's own location suggestedscripts/was where new tests belonged.They now live in
tests/, andmake test— the target CI runs — discovers from there.skill_eval.pystays behind; the Makefile mounts it into the container by path, so it is a tool, not a test.This is a pure move. Each module already computed the repo root as its parent directory and imported
swarmforgenormally, andtests/sits at the same depth asscripts/did, so the only edit inside the moved files is the path in the "Run:" line of each docstring. The README, the contributor notes, and two module docstrings that name their pinning test file are repointed to match.Verified with the same discovery run CI uses: 495 tests collected before and after, and the collected test IDs compare identical between the two revisions. Each file still runs standalone as its docstring claims. The launcher's byte-identical passthrough test and the
run_agent_containerargv tests — the two that pin behavior nothing here is allowed to move — pass unchanged.