Add a timeout for the WebSocket upgrade response - #88
Open
the-mikedavis wants to merge 1 commit into
Open
the-mikedavis wants to merge 1 commit into
the-mikedavis wants to merge 1 commit into
Conversation
Previously, if a server accepted the TCP connection but never responded
to the WebSocket upgrade request, the connection would wait forever. The
heartbeat timer only starts once the upgrade completes. Mint has a
connect timeout, but it only covers opening the TCP/TLS connection.
This change introduces an `upgrade_timeout_msec` option which defaults
to ten seconds (`0` to turn off). When that timeout elapses, the
connection is closed and `c:Slipstream.handle_disconnect/2` is invoked
with `{:error, :upgrade_timeout}`.
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a server accepted the TCP connection but never responded to the WebSocket upgrade request, the connection would wait forever. The heartbeat timer only starts once the upgrade completes. Mint has a connect timeout, but it only covers opening the TCP/TLS connection.
This change introduces an
upgrade_timeout_msecoption which defaults to ten seconds (0to turn off). When that timeout elapses, the connection is closed andc:Slipstream.handle_disconnect/2is invoked with{:error, :upgrade_timeout}.Fixes #75