docs(indexer): correct stale vendor-import comments - #87
Open
randomblocker wants to merge 1 commit into
Open
Conversation
verifyBundleCore's deep vendor-file import isn't blocked by a missing subpath export (dacs-sdk#14, closed) — it's exported from the agent barrel today, but that barrel also drags in createAgent/Agent.js and the substrate/bridge dependency chain, which breaks the production webpack build (confirmed: rubic-sdk -> cetus-sui-clmm-sdk -> a broken @mysten/bcs import). Document the real constraint instead. sessionAnchorName still isn't exported from any public barrel despite #14 listing it in scope and being closed as completed — filed dacs-sdk#178 to track it specifically and updated the comment to point there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyBundleCore's deep vendor-file import. It cited dacs-sdk#14 (now closed) as if the SDK simply lacked a subpath export — it now has one — but importing from the agent barrel drags increateAgent/Agent.jsand the full substrate/bridge chain (rubic-sdk→cetus-sui-clmm-sdk→ a broken@mysten/bcsimport), which breaks the production webpack build. Confirmed by trying the barrel import locally:npm run buildfails withAttempted import error: 'fromB64' is not exported from '@mysten/bcs'. Documented the real constraint instead of switching the import.sessionAnchorNameis still not exported from any public SDK barrel, despite dacs-sdk#14 listing it explicitly in scope and being closed as completed by dacs-sdk#48 (which only shippedrunSessionCore/SessionDeps). Filed dacs-sdk#178 to track it and updated the comment to point there instead of the closed fix(dacs-directory): detect #224 phase-index divergence in two-copy reconciliation #14.No functional change — comments only.
Validation
tsc --noEmit: passnpm test: 201/201 passnpm run build: pass