dotfiles-autoupdate: fetch the gantry CLI over ssh, not https - #132
Merged
Conversation
The https source needs a per-host credential helper: bonbon's gh helper
serves nothing in a non-interactive environment ("could not read
Username for 'https://github.com'"), so its first drift-fix failed at
0.192.2. Every gantry host has a working agent-less GitHub key — the
same path the daily pi refresh already exercises — so use git+ssh
directly instead of relying on the insteadOf rewrite existing.
Verified: ssh-URL install works on taffy (receipt now ssh://...).
Owner
Author
Review SummaryPost-merge review (PR merged at 2026-08-23 09:42 UTC before review completed). Direct single-pass review — 2 files, ~6 hand-written lines changed. FindingsNo P1–P3 findings. The change is correct and well-scoped:
P4 observations (informational only):
Verification
CommitNo fix commits — nothing to fix; PR head Verdict: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #131. The https source only authenticates where a credential helper happens to work: taffy passed because its insteadOf rewrite sent uv over SSH anyway, while bonbon's
ghhelper serves nothing non-interactively (could not read Username for 'https://github.com'), so its first drift-fix failed and left it at 0.192.2.Every gantry host has a working agent-less GitHub key — the same path the daily pi refresh already exercises from the timer environment — so
ensure_gantry_cli_fresh(and the skill doc's install recipe) now usegit+ssh://git@github.com/DJRHails/gantry@maindirectly.Verified on taffy: ssh-URL install succeeds, receipt now
git = "ssh://git@github.com/DJRHails/gantry?rev=main". Bonbon convergence will be verified post-merge by running the autoupdate there.via claude @ taffy