Skip to content

Rework the sample testing - #103

Open
illwieckz wants to merge 10 commits into
masterfrom
illwieckz/test
Open

Rework the sample testing#103
illwieckz wants to merge 10 commits into
masterfrom
illwieckz/test

Conversation

@illwieckz

@illwieckz illwieckz commented Aug 10, 2026

Copy link
Copy Markdown
Member

Rework the sample testing.

That's something I wanted to do and that was prompted by:

They even started to implement bits of that.

More changes than what was done in #98 and #98 were already wanted, but at the time I left them “for later”, “once those PR would be merged”. But in fact it's not a good strategy.

Now that I also wrote this:

I want to add more tests and I need those helpers being there.

Doing the tests in #102 without this code will just mean to write code to entirely rewrite it once this is merged.

So the least costly way of doing it is to merge this first, then to rebase and merge those others (in that order):

It's now very rare to not pass that argument,
so better use None in those rare cases than
maintaining the optionality of them.
Most of tests are loopable:

- converting from one format to all others,
- converting multiple files from a single test collection
  to a single directory,
- whole collection of clones…
- rename all the samples (but the icon) using a similar
  pattern.

This actually tests more combination.

This reorganize the out directories to make it easier to
review the files, and give the out directories better names.
Example of errors that would randomly surface in some test runs
when running them on wine in the Azure CI:

009c:err:rpc:I_RpcReceive we got fault packet with status 0x1c010003
wine client error:0: recvmsg: Connection reset by peer
@illwieckz

Copy link
Copy Markdown
Member Author

I imported this commit:

  • test: call wineserver -k before every wine run to avoid random errors

From:

As it's generic test rewrite, so it better belongs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant