Rework the sample testing - #103
Open
illwieckz wants to merge 10 commits into
Open
Conversation
It's now very rare to not pass that argument, so better use None in those rare cases than maintaining the optionality of them.
Most of tests are loopable: - converting from one format to all others, - converting multiple files from a single test collection to a single directory, - whole collection of clones… - rename all the samples (but the icon) using a similar pattern. This actually tests more combination. This reorganize the out directories to make it easier to review the files, and give the out directories better names.
Example of errors that would randomly surface in some test runs when running them on wine in the Azure CI: 009c:err:rpc:I_RpcReceive we got fault packet with status 0x1c010003 wine client error:0: recvmsg: Connection reset by peer
illwieckz
force-pushed
the
illwieckz/test
branch
5 times, most recently
from
August 10, 2026 06:40
88a3ff6 to
90c6dc8
Compare
Member
Author
|
I imported this commit:
From: As it's generic test rewrite, so it better belongs here. |
illwieckz
force-pushed
the
illwieckz/test
branch
from
August 10, 2026 07:09
0facec8 to
0623403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the sample testing.
That's something I wanted to do and that was prompted by:
They even started to implement bits of that.
More changes than what was done in #98 and #98 were already wanted, but at the time I left them “for later”, “once those PR would be merged”. But in fact it's not a good strategy.
Now that I also wrote this:
I want to add more tests and I need those helpers being there.
Doing the tests in #102 without this code will just mean to write code to entirely rewrite it once this is merged.
So the least costly way of doing it is to merge this first, then to rebase and merge those others (in that order):