Skip to content

Fix APK privacy scan false positives - #21

Merged
Darkaxt merged 1 commit into
masterfrom
fix/release-apk-privacy-scan
Aug 29, 2026
Merged

Darkaxt merged 1 commit into
masterfrom
fix/release-apk-privacy-scan

Conversation

@Darkaxt

@Darkaxt Darkaxt commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • require a complete Windows path segment instead of treating any drive-prefix bytes as private
  • preserve rejection of complete private paths embedded in binary assets
  • add the immutable RC78 hotfix 3 release metadata and NONPARSER_REUSE attestation

Verification

  • node --test tools/release/*.test.mjs (85/85)
  • privacy validator passes the exact unsigned APK artifact from failed run 33260746313
  • release evidence validates against RC77/schema 44 with Stage 7/8 closed
  • failed run completed policy, evidence, web, Gradle/lint/build, and packaged Android gates; no release was created

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T15:52:18.765505Z 69088e0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69088e0beb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


const PRIVATE_PATH_PATTERNS = [
/\b[A-Za-z]:[\\/]/,
/\b[A-Za-z]:[\\/][\p{L}\p{N}._ -]{1,128}[\\/]/u,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Match valid punctuation in Windows path segments

When an asset contains a Windows path whose first segment uses valid filename punctuation—for example, C:\Program Files (x86)\vendor\file—this character class stops at (, so the private-path scan accepts the asset. The same regression affects other valid characters and drive-root files such as C:\secret.txt; because this validator is the final privacy gate before release creation, those host paths could be published. Detect segment boundaries without restricting valid segment contents to this narrow allowlist.

Useful? React with 👍 / 👎.

@Darkaxt
Darkaxt merged commit 6d7f4ee into master Aug 29, 2026
7 of 8 checks passed
@Darkaxt
Darkaxt deleted the fix/release-apk-privacy-scan branch August 30, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant