Fix APK privacy scan false positives - #21
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69088e0beb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const PRIVATE_PATH_PATTERNS = [ | ||
| /\b[A-Za-z]:[\\/]/, | ||
| /\b[A-Za-z]:[\\/][\p{L}\p{N}._ -]{1,128}[\\/]/u, |
There was a problem hiding this comment.
Match valid punctuation in Windows path segments
When an asset contains a Windows path whose first segment uses valid filename punctuation—for example, C:\Program Files (x86)\vendor\file—this character class stops at (, so the private-path scan accepts the asset. The same regression affects other valid characters and drive-root files such as C:\secret.txt; because this validator is the final privacy gate before release creation, those host paths could be published. Detect segment boundaries without restricting valid segment contents to this narrow allowlist.
Useful? React with 👍 / 👎.
Summary
Verification
node --test tools/release/*.test.mjs(85/85)🤖 Generated with Claude Code