Skip to content

[DATASEC-357] Bump sds library - #57164

Closed
aimenebelfodil wants to merge 1 commit into
mainfrom
aimene.belfodil/datasec/bump-sds-lib
Closed

aimenebelfodil wants to merge 1 commit into
mainfrom
aimene.belfodil/datasec/bump-sds-lib

Conversation

@aimenebelfodil

@aimenebelfodil aimenebelfodil commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Bumps dd-sensitive-data-scanner from 0.1.0-20260807-dd8be015454d to 0.1.0-20260929-1251d82354ed (diff).

Relevant changes for the agent:

  • New secondary validators:
    • TokenEfficiencyCheck: smarter entropy check (#378).
    • NonHexPlusTokenEfficiencyChecker: NonHexChecker + TokenEfficiencyCheck (#386).
    • VinChecksum: VIN check digit for US/China rules (#391).

Motivation

Support scanning rules that use the new validators.

@github-actions github-actions Bot added the medium review PR review might take time label Sep 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

The patch is correct. The SDS version, Cargo and Bazel lockfiles, and third-party license inventory are updated consistently. No actionable regressions were identified. Build and runtime validation were unavailable in this read-only environment.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 62.56% (+4.28%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0a0a55e | Docs | Give us feedback!

@aimenebelfodil aimenebelfodil added qa/done QA done before merge and regressions are covered by tests changelog/no-changelog No changelog entry needed labels Sep 30, 2026
@aimenebelfodil
aimenebelfodil marked this pull request as ready for review September 30, 2026 09:44
@aimenebelfodil
aimenebelfodil requested review from a team as code owners September 30, 2026 09:44
@dd-octo-sts

dd-octo-sts Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor f712a7d5:

Results for datadog-agent_7.85.0~devel.git.822.0a0a55e.pipeline.141194265-1_amd64.deb:

Detected file changes:

1 Changed files:

  • etc/datadog-agent/checks.d/libdatadog-agent-datasecurity.so:
    • Size changed: +46.56% (1.75 MiB) (3.76 MiB -> 5.51 MiB)

Results for datadog-iot-agent_7.85.0~devel.git.822.0a0a55e.pipeline.141194265-1_amd64.deb:

No change detected

@aimenebelfodil
aimenebelfodil marked this pull request as draft September 30, 2026 09:47
@aimenebelfodil
aimenebelfodil marked this pull request as ready for review September 30, 2026 09:47

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

patch is correct. No actionable regressions found in the dependency bump or associated lockfile and license updates. Dependency metadata is consistent. Build and runtime validation were unavailable because the dependency sources are not cached locally.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

patch is correct. No actionable regressions found in the dependency bump, lockfile updates, or license inventory. Build and runtime compatibility remain unverified because dependency sources are unavailable locally.

@dd-octo-sts

dd-octo-sts Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

❌ Please find below the results from static quality gates
Comparison made with ancestor f712a7d
📊 Static Quality Gates Dashboard
🔗 SQG Job
⚠️ Exception granted by @alopezz: this PR exceeds the per-PR size thresholds but will not be blocked.

Error

Quality gate Change Size (prev → curr → max)
❌ agent_deb_amd64 (on disk) +1.75 MiB (0.22% increase, -182.82% of buffer) 785.823 → 787.573 → 786.780
❌ agent_deb_amd64_fips (on disk) +1.75 MiB (0.24% increase, -142.26% of buffer) 719.120 → 720.870 → 720.350
⚠️ agent_heroku_amd64 (per-PR threshold) +1.75 MiB (0.55% increase, -32.56% of buffer) 317.805 → 319.555 → 323.180
❌ agent_rpm_amd64 (on disk) +1.75 MiB (0.22% increase, -185.48% of buffer) 785.806 → 787.557 → 786.750
❌ agent_rpm_amd64_fips (on disk) +1.75 MiB (0.24% increase, -140.40% of buffer) 719.103 → 720.854 → 720.350
⚠️ agent_rpm_arm64 (per-PR threshold) +1.73 MiB (0.23% increase, -82.28% of buffer) 756.551 → 758.278 → 758.650
⚠️ agent_rpm_arm64_fips (per-PR threshold) +1.73 MiB (0.25% increase, -63.65% of buffer) 695.417 → 697.144 → 698.130
❌ agent_suse_amd64 (on disk) +1.75 MiB (0.22% increase, -185.48% of buffer) 785.806 → 787.557 → 786.750
❌ agent_suse_amd64_fips (on disk) +1.75 MiB (0.24% increase, -140.40% of buffer) 719.103 → 720.854 → 720.350
⚠️ agent_suse_arm64 (per-PR threshold) +1.73 MiB (0.23% increase, -82.28% of buffer) 756.551 → 758.278 → 758.650
⚠️ agent_suse_arm64_fips (per-PR threshold) +1.73 MiB (0.25% increase, -63.65% of buffer) 695.417 → 697.144 → 698.130
⚠️ docker_agent_amd64 (per-PR threshold) +1.75 MiB (0.21% increase, -58.68% of buffer) 842.097 → 843.848 → 845.080
⚠️ docker_agent_arm64 (per-PR threshold) +1.73 MiB (0.21% increase, -33.69% of buffer) 837.485 → 839.211 → 842.610
⚠️ docker_agent_jmx_amd64 (per-PR threshold) +1.75 MiB (0.17% increase, -57.71% of buffer) 1032.967 → 1034.717 → 1036.000
⚠️ docker_agent_jmx_arm64 (per-PR threshold) +1.73 MiB (0.17% increase, -33.43% of buffer) 1017.134 → 1018.861 → 1022.300
Gate failure full details
Quality gate Error type Error message
agent_deb_amd64 AbsoluteLimitExceeded static_quality_gate_agent_deb_amd64 failed!
Disk size 787.6 MB exceeds limit of 786.8 MB by 811.9 KB
agent_deb_amd64_fips AbsoluteLimitExceeded static_quality_gate_agent_deb_amd64_fips failed!
Disk size 720.9 MB exceeds limit of 720.3 MB by 532.4 KB
agent_heroku_amd64 PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.75 MiB exceeds the per-PR threshold of 600.0 KiB
agent_rpm_amd64 AbsoluteLimitExceeded static_quality_gate_agent_rpm_amd64 failed!
Disk size 787.6 MB exceeds limit of 786.8 MB by 826.0 KB
agent_rpm_amd64_fips AbsoluteLimitExceeded static_quality_gate_agent_rpm_amd64_fips failed!
Disk size 720.9 MB exceeds limit of 720.3 MB by 515.7 KB
agent_rpm_arm64 PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.73 MiB exceeds the per-PR threshold of 600.0 KiB
agent_rpm_arm64_fips PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.73 MiB exceeds the per-PR threshold of 600.0 KiB
agent_suse_amd64 AbsoluteLimitExceeded static_quality_gate_agent_suse_amd64 failed!
Disk size 787.6 MB exceeds limit of 786.8 MB by 826.0 KB
agent_suse_amd64_fips AbsoluteLimitExceeded static_quality_gate_agent_suse_amd64_fips failed!
Disk size 720.9 MB exceeds limit of 720.3 MB by 515.7 KB
agent_suse_arm64 PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.73 MiB exceeds the per-PR threshold of 600.0 KiB
agent_suse_arm64_fips PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.73 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_amd64 PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.75 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_arm64 PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.73 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_jmx_amd64 PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.75 MiB exceeds the per-PR threshold of 600.0 KiB
docker_agent_jmx_arm64 PerPRThresholdExceeded (non-blocking: exception granted by @alopezz) On-disk size increase of 1.73 MiB exceeds the per-PR threshold of 600.0 KiB

Static quality gate failures prevent this PR from merging!
You can check the static quality gates runbooks page for guidance and tools. Please either fix the size violation or request an exception.

18 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
✅ agent_msi 653.054 MiB
✅ docker_cws_instrumentation_amd64 7.439 MiB
✅ docker_cws_instrumentation_arm64 6.877 MiB
✅ docker_dogstatsd_amd64 39.425 MiB
✅ docker_dogstatsd_arm64 37.503 MiB
✅ docker_host_profiler_amd64 308.199 MiB
✅ docker_host_profiler_arm64 319.372 MiB
✅ dogstatsd_deb_amd64 30.165 MiB
✅ dogstatsd_deb_arm64 28.181 MiB
✅ dogstatsd_rpm_amd64 30.165 MiB
✅ dogstatsd_suse_amd64 30.165 MiB
✅ iot_agent_deb_amd64 46.619 MiB
✅ iot_agent_deb_arm64 43.240 MiB
✅ iot_agent_deb_armhf 44.061 MiB
✅ iot_agent_rpm_amd64 46.620 MiB
✅ iot_agent_suse_amd64 46.619 MiB
✅ docker_cluster_agent_amd64 213.874 MiB
✅ docker_cluster_agent_arm64 226.788 MiB

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 96ab6f60-6a0c-42e3-84d3-3c0fef896525

Baseline: ce30811
Comparison: 0a0a55e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
➖ quality_gate_metrics_logs memory utilization +0.74 [+0.51, +0.97] 1 Logs bounds checks dashboard
➖ quality_gate_security_no_fs_load memory utilization +0.30 [+0.23, +0.37] 1 Logs bounds checks dashboard
➖ dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization +0.21 [+0.00, +0.43] 1 Logs
➖ quality_gate_security_mean_fs_load memory utilization +0.02 [-0.03, +0.07] 1 Logs bounds checks dashboard
➖ python_openmetrics % cpu utilization +0.00 [-0.68, +0.69] 1 Logs bounds checks dashboard
➖ quality_gate_private_action_runner memory utilization -0.05 [-0.17, +0.08] 1 Logs bounds checks dashboard
➖ quality_gate_security_idle memory utilization -0.22 [-0.26, -0.18] 1 Logs bounds checks dashboard
➖ quality_gate_idle_all_features memory utilization -0.29 [-0.35, -0.23] 1 Logs bounds checks dashboard
➖ quality_gate_idle memory utilization -0.37 [-0.41, -0.33] 1 Logs bounds checks dashboard
➖ dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.66 [-0.89, -0.43] 1 Logs
➖ quality_gate_logs % cpu utilization -0.88 [-1.73, -0.03] 1 Logs bounds checks dashboard
➖ dsd_uds_client_drop_detector_cpu % cpu utilization -2.38 [-2.86, -1.89] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
✅ python_openmetrics checks_execution_time 10/10 77.47 ≤ 100 bounds checks dashboard
✅ python_openmetrics cpu_usage 10/10 1330.62 ≤ 1500 bounds checks dashboard
✅ python_openmetrics memory_usage 10/10 4.32GiB ≤ 4.75GiB bounds checks dashboard
✅ quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
✅ quality_gate_idle memory_usage 10/10 176.38MiB ≤ 181MiB bounds checks dashboard
✅ quality_gate_idle total_bytes_received 10/10 760.71KiB ≤ 819.20KiB bounds checks dashboard
✅ quality_gate_idle_all_features intake_connections 10/10 2 ≤ 5 bounds checks dashboard
✅ quality_gate_idle_all_features memory_usage 10/10 465.09MiB ≤ 542MiB bounds checks dashboard
✅ quality_gate_idle_all_features total_bytes_received 10/10 1.12MiB ≤ 1.25MiB bounds checks dashboard
✅ quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
✅ quality_gate_logs memory_usage 10/10 214.17MiB ≤ 228MiB bounds checks dashboard
✅ quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_logs total_bytes_received 10/10 263.47MiB ≤ 292MiB bounds checks dashboard
✅ quality_gate_metrics_logs cpu_usage 10/10 368.01 ≤ 2000 bounds checks dashboard
✅ quality_gate_metrics_logs intake_connections 10/10 20 ≤ 40 bounds checks dashboard
✅ quality_gate_metrics_logs memory_usage 10/10 433.95MiB ≤ 455MiB bounds checks dashboard
✅ quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
✅ quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
✅ quality_gate_private_action_runner memory_usage 10/10 73.27MiB ≤ 75MiB bounds checks dashboard
✅ quality_gate_security_idle cpu_usage 10/10 30.42 ≤ 100 bounds checks dashboard
✅ quality_gate_security_idle memory_usage 10/10 322.62MiB ≤ 357MiB bounds checks dashboard
✅ quality_gate_security_mean_fs_load cpu_usage 10/10 64.41 ≤ 200 bounds checks dashboard
✅ quality_gate_security_mean_fs_load memory_usage 10/10 311.19MiB ≤ 337MiB bounds checks dashboard
✅ quality_gate_security_no_fs_load cpu_usage 10/10 22.39 ≤ 100 bounds checks dashboard
✅ quality_gate_security_no_fs_load memory_usage 10/10 316.72MiB ≤ 348MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-build team/agent-devx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants