Stop duplicate CI runs on PR branches - #166
Merged
Merged
Conversation
`on: [push, pull_request]` fired both events for the same commit when a branch had an open PR, doubling every lint/unit/integration run. Restrict `push` to `main` so PR branches only trigger `pull_request`, and add a concurrency group to cancel superseded PR runs when new commits land. Merges to main are still verified.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3355b8c1a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The duplicate-run fix is handled entirely by restricting `push` to `main`; the concurrency block only cancelled superseded PR runs on rapid commits, which is optional. Keep the diff minimal and focused.
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions build workflow triggers to avoid duplicate CI runs on PR branches by running CI on pull_request events for PR work and limiting push runs to the main branch.
Changes:
- Replaces
on: [push, pull_request]with explicitpull_requestandpush(restricted tomain) triggers. - Adds an inline
yamllintsuppression for theon:key to satisfy YAML linting.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
joeyzhao2018
approved these changes
Aug 17, 2026
Strech
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
on: [push, pull_request]fires both events for the same commit when a branch has an open PR, so everybuildjob runs twice. This is visible on recent PRs (e.g. #164) where each job —lint,unit-test (3.2),integration-test (4.0), … — appears under two run IDs. Doubles CI wall-time and AWS sandbox usage per PR.Fix
Restrict
pushtomain:pull_requestfires → one run per commit (no duplicate).main→pushfires → still verified.Why not
cancel-in-progresson all branches?The alternative — keep
pushon all branches and rely on aconcurrencyblock withcancel-in-progress: trueto dedup — leaves the cancelled run reportingcancelled(notsuccess). Per GitHub's required-checks docs, onlysuccess/skipped/neutralsatisfy a required check. This repo has a custom merge gate (devflow/mergegate+DDCI Status+dd-gitlab/*), and introducingcancelledcheck states into a gate we don't control is risky. Restrictingpushtomainmeans the duplicate never fires in the first place — no cancellation race, no ambiguous check state.References: Adam Johnson, runs-on.com concurrency guide.
Trade-off
Pushes to a feature branch with no open PR no longer get CI — you get CI once the PR is opened. (This matches the behavior of most of Datadog's other serverless repos.)
Other workflows
Unchanged:
check-size.yml→pull_requestonlypublish.yml→workflow_dispatchonlycodeql-analysis.yml→ standalone