SDSP-587: dispatch downstream bumps after crate publication - #394
Merged
Merged
Conversation
GeoffreyRdn
marked this pull request as ready for review
September 23, 2026 15:18
fbryden
reviewed
Sep 24, 2026
| | jq -se --arg version "$CRATE_VERSION" 'any(.[]; .vers == $version and .yanked == false)' > /dev/null; then | ||
| exit 0 | ||
| fi | ||
| if [ "$attempt" -lt 12 ]; then |
Contributor
There was a problem hiding this comment.
I don't understand why we need this if, but it's probably not a big deal
(is attempt not always less than 12?)
Contributor
Author
There was a problem hiding this comment.
It is inclusive, so 12 can be triggered in the last round. Basically we wait except for last try.
Proof:
for attempt in {1..12}; do echo $attempt; done
1
2
3
4
5
6
7
8
9
10
11
12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downstream dependency bump currently runs independently of crate publication, sends a Git commit hash, and targets the old repository organization. Dispatch failures can also leave the workflow green.
This change calls the reusable dispatch workflow after successful publication on main, passes the exact published crate version, and verifies that it is available and not yanked in the crates.io index. Dry runs and non-main releases skip dispatch. GitHub App token creation and dispatch target ddoghq/sds-shared-library, HTTP errors fail the job, and JSON payloads are built with jq. Direct pushes without a linked PR use the commit URL and triggering user as metadata.
JIRA: SDSP-587