Conversation
fuchsnj
approved these changes
Sep 25, 2026
aimenebelfodil
approved these changes
Sep 26, 2026
aimenebelfodil
left a comment
aimenebelfodil
left a comment
Contributor
There was a problem hiding this comment.
LGTM Thanks for your patience David!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDSP-592
Follow up on the review feedback on #391: move VIN checksum coverage into inline Rust unit tests beside the validator, following the existing secondary-validator pattern. Remove the separate scanner test module and standalone Go test file, keeping one lightweight test in
scanner_test.goto verify the validator works through the Go bindings.The validator implementation is unchanged.