Skip to content

Auto-activate php easy wins for apm-sdk-capabilities - #7897

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/apm-sdk-capabilities/php
Open

dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/apm-sdk-capabilities/php

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Automated activation of easy-win tests for php owned by apm-sdk-capabilities
View nightly workflow run

  • Auto-merge is enabled unless the team opted out for this library.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

@dd-octo-sts
dd-octo-sts Bot marked this pull request as ready for review October 1, 2026 07:00
@dd-octo-sts
dd-octo-sts Bot requested a review from a team as a code owner October 1, 2026 07:00
@dd-octo-sts
dd-octo-sts Bot enabled auto-merge (squash) October 1, 2026 07:00
@dd-prapprover-prod-77c48c

dd-prapprover-prod-77c48c Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

PRApprover will approve and merge this PR, FAQ, #dx-source-code-management

🛠️ PRApproval Status

  • ✅ PR is eligible for auto-approval by rule system-tests-auto-activate-easy-wins - 2026-10-04T07:33:28Z
  • ⬜ CI tests passed
  • ⬜ Approved
  • Manual merge required: this rule does not auto-merge.

➡️ Current phase: CI tests failed. Please fix the failing tests and rerun the workflow, click Workflow Link -> Workflow Starter Link -> Start Workflow

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/system-tests-reviewers

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4efbaafeb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/php.yml
Comment thread manifests/php.yml
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 5 Pipeline jobs failed

Testing the test | System Tests (php, dev) / parametric / parametric (1) — ❌ 3 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌ tests.parametric.test_dynamic_configuration.TestDynamicConfigSamplingRules.test_trace_sampling_rules_override_rate[library_env0, parametric-php] from system_tests_suite
assert 1.0 == 0.8 ± 8.0e-07
  comparison failed
  Obtained: 1.0
  Expected: 0.8 ± 8.0e-07

self = <tests.parametric.test_dynamic_configuration.TestDynamicConfigSamplingRules object at 0x7f58a1b26c90>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f586dc51940>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f586ed497c0>

    @parametrize("library_env", [{**DEFAULT_ENVVARS}])
...
❌ tests.parametric.test_dynamic_configuration.TestDynamicConfigV1.test_trace_sampling_rate_with_sampling_rules[library_env0, parametric-php] from system_tests_suite
assert 1.0 == 0.7 ± 7.0e-07
  comparison failed
  Obtained: 1.0
  Expected: 0.7 ± 7.0e-07

self = <tests.parametric.test_dynamic_configuration.TestDynamicConfigV1 object at 0x7f8ba96fc110>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f8b75df95b0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f8b76487e00>

    @parametrize(
...
❌ tests.parametric.test_dynamic_configuration.Test_DynamicConfigSdkConfiguration.test_capability_sdk_configuration[library_env0, parametric-php] from system_tests_suite
AssertionError: RemoteConfig capabilities missing: {<Capabilities.SDK_CONFIGURATION: 49>}; seen: {<Capabilities.ASM_ACTIVATION: 1>, <Capabilities.ASM_IP_BLOCKING: 2>, <Capabilities.ASM_DD_RULES: 3>, <Capabilities.ASM_EXCLUSIONS: 4>, <Capabilities.ASM_REQUEST_BLOCKING: 5>, <Capabilities.ASM_ASM_RESPONSE_BLOCKING: 6>, <Capabilities.ASM_USER_BLOCKING: 7>, <Capabilities.ASM_CUSTOM_RULES: 8>, <Capabilities.ASM_CUSTOM_BLOCKING_RESPONSE: 9>, <Capabilities.ASM_TRUSTED_IPS: 10>, <Capabilities.APM_TRACING_SAMPLE_RATE: 12>, <Capabilities.APM_TRACING_LOGS_INJECTION: 13>, <Capabilities.APM_TRACING_HTTP_HEADER_TAGS: 14>, <Capabilities.APM_TRACING_CUSTOM_TAGS: 15>, <Capabilities.ASM_PROCESSOR_OVERRIDES: 16>, <Capabilities.ASM_CUSTOM_DATA_SCANNERS: 17>, <Capabilities.APM_TRACING_ENABLED: 19>, <Capabilities.ASM_RASP_SQLI: 21>, <Capabilities.ASM_RASP_LFI: 22>, <Capabilities.ASM_RASP_SSRF: 23>, <Capabilities.APM_TRACING_SAMPLE_RULES: 29>, <Capabilities.ASM_AUTO_USER_INSTRUM_MODE: 31>, <Capabilities.ASM_ENDPOINT_FINGERPRINT: 32>, <Capabilities.ASM_SESSION_FINGERPRINT: 33>, <Capabilities.ASM_NETWORK_FINGERPRINT: 34>, <Capabilities.ASM_HEADER_FINGERPRINT: 35>, <Capabilities.ASM_DD_MULTICONFIG: 42>, <Capabilities.ASM_TRACE_TAGGING_RULES: 43>, <Capabilities.APM_TRACING_MULTICONFIG: 45>}

self = <tests.parametric.test_dynamic_configuration.Test_DynamicConfigSdkConfiguration object at 0x7f8ba96f41d0>
test_agent = <utils.docker_fixtures._test_agent.TestAgentAPI object at 0x7f8b75df95b0>
test_library = <utils.docker_fixtures._test_clients._test_client_parametric.ParametricTestClientApi object at 0x7f8baa93b410>

    @parametrize("library_env", [{**DEFAULT_ENVVARS}])
    def test_capability_sdk_configuration(self, test_agent: TestAgentAPI, test_library: APMLibrary) -> None:
        """Ensure the RC request contains the sdk_config capability."""
        assert test_library.is_alive(), "library container is not alive"
...
Testing the test | System Tests (php, prod) / parametric / parametric (1) — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Testing the test | all-jobs-are-green — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

View all 5 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b145cd0 | Docs | View more details | Give us feedback!

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-sdk-capabilities/php branch 2 times, most recently from b25f0b7 to f0f80ab Compare October 3, 2026 06:50
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/apm-sdk-capabilities/php branch from f0f80ab to b145cd0 Compare October 4, 2026 07:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants