Conversation
Contributor
|
|
vpellan
added this pull request to stack #7926
October 2, 2026 13:51
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 104 Pipeline jobs failed ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: d61ed30 | Docs | View more details | Give us feedback! |
vpellan
marked this pull request as ready for review
October 2, 2026 14:09
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
MilanGarnier
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Split the temporality work for APMAPI-2555 so the code relocation can be reviewed independently of new coverage.
Stack 1/2: this PR targets
main. The additional coverage is in #7924, based on this branch. Review and merge this PR first.Changes
Move the existing
Test_Otel_Metrics_Configuration_Temporality_Preferenceclass intotests/parametric/otel_env_vars/test_otel_exporter_otlp_metrics_temporality_preference.py. Preserve its name, feature/scenario decorators, environment settings, three parameter cases (unset, DELTA, CUMULATIVE), and complete assertion body.Extract the existing metric constants and helper functions into the existing
tests/parametric/otel_env_vars/utils.py, and import them from both test files. Helper annotations are updated to satisfy linting outside atest_*.pymodule; their runtime logic is unchanged. All existing constants are retained. Usingutils.pyfollows the test-helper naming convention enforced byTEST_THE_TEST.Relocate the class/method manifest entries and copy the inherited file-level declarations to the new path, preserving effective support and skip conditions. Feature attribution and expanded support declarations belong to the second PR.
Validation
./run.sh TEST_THE_TEST tests/test_the_test/test_conventions.py: passed with the helpers inotel_env_vars/utils.py.--skip-parametric-build../format.sh: passed, including mypy, import policy, Ruff, YAML/manifest validation, shellcheck, and Node.js linters. An unrelated empty, untrackedutils/build/docker/internal_server/app.shdirectory was temporarily moved for shellcheck and restored afterward.