Skip to content

[1/2] Move existing OTLP metrics temporality tests and helpers - #7925

Open
vpellan wants to merge 2 commits into
mainfrom
vpellan/move-otel-metrics-temporality-tests
Open

vpellan wants to merge 2 commits into
mainfrom
vpellan/move-otel-metrics-temporality-tests

Conversation

@vpellan

@vpellan vpellan commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Split the temporality work for APMAPI-2555 so the code relocation can be reviewed independently of new coverage.

Stack 1/2: this PR targets main. The additional coverage is in #7924, based on this branch. Review and merge this PR first.

Changes

Move the existing Test_Otel_Metrics_Configuration_Temporality_Preference class into tests/parametric/otel_env_vars/test_otel_exporter_otlp_metrics_temporality_preference.py. Preserve its name, feature/scenario decorators, environment settings, three parameter cases (unset, DELTA, CUMULATIVE), and complete assertion body.

Extract the existing metric constants and helper functions into the existing tests/parametric/otel_env_vars/utils.py, and import them from both test files. Helper annotations are updated to satisfy linting outside a test_*.py module; their runtime logic is unchanged. All existing constants are retained. Using utils.py follows the test-helper naming convention enforced by TEST_THE_TEST.

Relocate the class/method manifest entries and copy the inherited file-level declarations to the new path, preserving effective support and skip conditions. Feature attribution and expanded support declarations belong to the second PR.

Validation

  • ./run.sh TEST_THE_TEST tests/test_the_test/test_conventions.py: passed with the helpers in otel_env_vars/utils.py.
  • Structural comparison confirms all original metric test classes, helper runtime bodies, and constant values are preserved.
  • Compared effective declarations for the moved test across every manifest: unchanged.
  • Node.js 7.0.0-pre: all three relocated cases passed with --skip-parametric-build.
  • ./format.sh: passed, including mypy, import policy, Ruff, YAML/manifest validation, shellcheck, and Node.js linters. An unrelated empty, untracked utils/build/docker/internal_server/app.sh directory was temporarily moved for shellcheck and restored afterward.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/parametric/otel_env_vars/test_otel_exporter_otlp_metrics_temporality_preference.py  @DataDog/system-tests-reviewers
manifests/cpp.yml                                                       @DataDog/system-tests-reviewers
manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers
tests/parametric/otel_env_vars/utils.py                                 @DataDog/system-tests-reviewers
tests/parametric/test_otel_metrics.py                                   @DataDog/system-tests-reviewers

@datadog-official

datadog-official Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 104 Pipeline jobs failed

Testing the test | all-jobs-are-green — 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

Testing the test | System Tests (cpp_httpd, dev) / End-to-end #1 / httpd 1

View more details · View in GitHub Actions

Testing the test | System Tests (cpp_httpd, prod) / End-to-end #1 / httpd 1

View more details · View in GitHub Actions

View all 104 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d61ed30 | Docs | View more details | Give us feedback!

@vpellan
vpellan marked this pull request as ready for review October 2, 2026 14:09
@vpellan
vpellan requested a review from a team as a code owner October 2, 2026 14:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-02T14:12:48.252455Z b9f1250 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants