Skip to content

docs: broad code review before continuing migration - #22

Merged
chasetmartin merged 1 commit into
mainfrom
ST2DAT-183-code-review-with-jake-before-additional-source-migration
Aug 19, 2026
Merged

docs: broad code review before continuing migration#22
chasetmartin merged 1 commit into
mainfrom
ST2DAT-183-code-review-with-jake-before-additional-source-migration

Conversation

@chasetmartin

Copy link
Copy Markdown
Collaborator

Why

This PR addresses the following problem / context:

  • The point of this PR is to have a PR that Jake can use to leave code comments for ST2DAT-183.
  • New source mapping template (docs/sources/_mapping_template.md) wasn't referenced anywhere discoverable from the README

How

Implementation summary - the following was changed / added / removed:

  • Simple readme update that needed to happen to have a PR to review

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Docs-only change, no code impact, PR for broad code review

@chasetmartin
chasetmartin requested a review from jirhiker July 8, 2026 17:38
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
aqueduct_dagster_defs_definitions View in Cloud Aug 19, 2026 at 08:45 PM (UTC)

@chasetmartin chasetmartin changed the title docs: point to source mapping template in README docs: broad code review before continuing migration Jul 8, 2026
@chasetmartin
chasetmartin force-pushed the ST2DAT-183-code-review-with-jake-before-additional-source-migration branch from 247ff2b to 935b288 Compare July 22, 2026 20:51
@chasetmartin
chasetmartin force-pushed the ST2DAT-183-code-review-with-jake-before-additional-source-migration branch from 935b288 to c1adf18 Compare August 7, 2026 16:28
@chasetmartin
chasetmartin force-pushed the ST2DAT-183-code-review-with-jake-before-additional-source-migration branch from c1adf18 to c9d8e10 Compare August 19, 2026 20:42
@chasetmartin
chasetmartin merged commit 0a012a6 into main Aug 19, 2026
5 checks passed
@chasetmartin
chasetmartin deleted the ST2DAT-183-code-review-with-jake-before-additional-source-migration branch August 19, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants