feat(chemistry-well-details): add new items from Mock-up #3 requirements - #1
Open
TylerAdamMartinez wants to merge 2 commits into
Open
feat(chemistry-well-details): add new items from Mock-up #3 requirements#1TylerAdamMartinez wants to merge 2 commits into
TylerAdamMartinez wants to merge 2 commits into
Conversation
Implemented the following: * Remove the prominent single-event note from the multi-sample view * Keep the sampling-event note as a table column or expandable row detail * Keep parameter notes available for exceptions, such as an ORP measurement that did not stabilize. * Add the Additional Analyses cross-tab. * Update isotope labels to consistent delta notation, including superscript isotope numbers such as δ13C. * Highlight exceeding values in red and bold. * Remove detection limits and errors from the quick display. * Add ion balance as a per-sample General Chemistry column. * Remove ion balance as a note above the table. * Create cross-tab for all views option
|
@TylerAdamMartinez Looks good, there were only two acceptance critieria that I cannot confirm, 1. Inventory legacy chemistry parameters and initially order them by database order - I think this means what you created in the fourth tab, but please confirm. 2. Create cross-tab for all views - specific to parameters tab, but I don't see the difference between this version and the previous one. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test this PR by opening the https://raw.githubusercontent.com/DataIntegrationGroup/OcotilloMockups/refs/heads/story/bdms-1053-chemistry-display-mock-3/chemistry-well-details-mockup.html file in your browser.