chore(nav): drop the Sandbox concept - #358
Open
jirhiker wants to merge 1 commit into
Open
Conversation
The Sandbox nav group mixed a typography specimen with three WIP geothermal grids, and its visibility flag treated staging as a place to try things out. Previews are the sandbox now: a PR preview can run against an ephemeral API nobody else shares, while staging is a pre-production release branch. - Remove the Sandbox nav group and its SHOW_EXAMPLE_NAV flag. The pages it linked (/example/typography and the three geothermal grids) stay routable by URL; a geothermal nav group lands separately. - Remove the Sandbox access-control resource, the 'Sandbox' parent on ocotillo.hydrograph-correction, and the Sandbox label case in the Refine sider. - Document the staging-vs-preview rule in AGENTS.md and update the docs that described nav placement as Sandbox. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jirhiker
force-pushed
the
chore/remove-sandbox-concept
branch
from
August 22, 2026 18:09
482705b to
1e7b505
Compare
jirhiker
changed the title
Preview DeploymentPreview URL: https://preview-chore-remove-sandbox-concept-auejgdbofq-uc.a.run.app |
1 similar comment
Preview DeploymentPreview URL: https://preview-chore-remove-sandbox-concept-auejgdbofq-uc.a.run.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the Sandbox concept from the app and the docs. No replacement nav group in this PR — the geothermal nav group lands separately.
Why
The Sandbox group mixed a typography specimen with three WIP geothermal grids, and its visibility flag treated
stagingas a place to try things out. Preview deploys are the sandbox — a PR preview can run against an ephemeral API nobody else shares.stagingis a pre-production release branch: what lands there is a candidate forproduction.Changes
Nav
ExampleNavItem) and theSHOW_EXAMPLE_NAVflag it was gated on./example/typography,/geothermal/wells/records-grid,/geothermal/wells/inventory,/geothermal/wells/temp-depth. Routes and pages are untouched.Sandbox resource
Sandboxaccess-control resource and its branch in the resource switch.ocotillo.hydrograph-correctionno longer setsparent: 'Sandbox'— it was nested under a group that no longer exists, and it is already top-level inRESOURCE_NAV.name === 'Sandbox'label special-case in the Refine sider.isResourceListAdminOnly('Sandbox')assertion.Docs
AGENTS.md: new "Where unfinished work gets exercised" section — previews are the sandbox,stagingis a pre-production release branch, and WIP gates key off dev or preview only (asrecordsGridLogic.tsalready does). Do not add a staging arm.access-control-ruleset.md,geothermal-well-inventory.md,geothermal-well-search-contract.md, and the picker doc comments updated.preview-deployments.mdkeeps its "sandbox" wording — there it means preview-as-sandbox, which is the point.Follow-up
A Geothermal nav group for Records / Inventory / Temp-Depth is deliberately left out of this PR.
Verification
npm run typecheckclean.AppShell.tsxcarries pre-existing format debt; unrelated lines were not reformatted).accessControl.test.ts36/36 pass. The 12 failing files repo-wide are theECONNREFUSED 127.0.0.1:4010contract tests that need the Prism mock (npm run mock:server:cypress); they are untouched by this change./geothermal/wells/records-gridstill loads by URL, no console errors.🤖 Generated with Claude Code