feat: Expose remaining graphql-java ParserOptions settings in vertx-config.json - #2277
Merged
Merged
Conversation
…onfig.json Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
============================================
+ Coverage 18.78% 18.80% +0.01%
- Complexity 1223 1226 +3
============================================
Files 630 630
Lines 18409 18413 +4
Branches 2250 2250
============================================
+ Hits 3459 3463 +4
Misses 14618 14618
Partials 332 332 ☔ View full report in Codecov by Harness. |
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
ferenc-csaky
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2276, which exposed only the four integer limits of graphql-java's
ParserOptions. This adds the remaining settings that sit alongside them.Change
graphQLParserConfignow covers everythingParserOptions.Builderexposes:The five new flags are
Boolean, notboolean, and default to null. That is deliberate: graphql-java does not use one value across all parsers. Dumping the 26.0 defaults:captureIgnoredCharscaptureSourceLocationcaptureLineCommentsreaderTrackDataredactTokenParserErrorMessagescaptureLineCommentsdiffers between generic and operation parsing, so baking a single primitive default into the config would silently flip operation parsing totruefor every deployment. A null flag is left untouched, preserving whatever graphql-java defaults to for the parser being configured; a non-null flag is applied to both. Behaviour is unchanged when the section is absent or left at its defaults.parsingListeneris the one builder setting not exposed — it takes a callback implementation, which cannot be expressed in a config file.Testing
GraphQLParserConfigTest— new cases for the flags being applied to both parser defaults, and for unset flags preserving the generic-vs-operationcaptureLineCommentssplit rather than flattening it.ServerConfigTest— the flags deserialize from the config section.ServerConfigTemplateTest— template round-trip with the new nullable keys.ServerFunctionContainerITre-run against freshly built:localimages, so the server is verified to still start and parse with the new nullable keys present invertx-config.json.Full
mvn testis green.