ci: hold _PHPUNIT_CONCURRENT at 0 for gitlab_templates 1.17.0 - #39
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe GitLab CI configuration adds ChangesCI test configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change preserves the existing PHPUnit execution path without introducing an actionable merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.x-1.x #39 +/- ##
========================================
Coverage 83.66% 83.66%
========================================
Files 20 20
Lines 796 796
========================================
Hits 666 666
Misses 130 130 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
Drupal.org's GitLab CI templates changed the default for
_PHPUNIT_CONCURRENTfrom 0 to 1 in gitlab_templates 1.17.0, released on 9 September (https://www.drupal.org/node/3620894). Thephpunitjob now runs core'srun-tests.shinstead of thephpunitbinary.This module passes its CI configuration as
--configuration=phpunit.gitlab-ci.xmlin_PHPUNIT_EXTRA. The template copies that into_RUNTESTS_EXTRAas--phpunit-configuration phpunit.gitlab-ci.xml.run-tests.shchanges directory into the Drupal root and hands the relative path straight to PHPUnit, which then looks forweb/phpunit.gitlab-ci.xml. The file is in the project root, so the job stops before any test runs:Drupal 10's
run-tests.shhas no--phpunit-configurationoption at all, so the Drupal 10 jobs would fail as well.Fix
.gitlab-ci.ymlsets_PHPUNIT_CONCURRENT: 0. Thephpunitjob runs thephpunitbinary from the project root again, as it did before 9 September.Proof
On https://git.drupalcode.org/project/filefield_paths/-/merge_requests/80, pipeline 956957 failed in
phpunitwith the error above (https://git.drupalcode.org/project/filefield_paths/-/jobs/12125579). With this commit added on top, pipeline 956994 passed (https://git.drupalcode.org/project/filefield_paths/-/jobs/12126314). That job ran with_PHPUNIT_CONCURRENT=0, loaded/builds/project/filefield_paths/phpunit.gitlab-ci.xmland ran 177 tests. Every other job passed in both pipelines. The commit came off that merge request again afterwards.Moving to
run-tests.shon purpose, with an absolute configuration path, is a separate decision.Summary by CodeRabbit