chore: route CI through just and consolidate recipes - #126
Merged
Conversation
Make justfile the single source for local and CI build/test entrypoints, collapse overlapping gate/dev/cases/build helpers, and stop invoking raw cargo/uv commands from the main CI workflow. Co-authored-by: Cursor <cursoragent@cursor.com>
Variadic recipe arguments are not exposed as $@ in shebang recipes on the pinned just version, so package names never reached nextest. Co-authored-by: Cursor <cursoragent@cursor.com>
Use +packages so missing args fail in just itself, and expand package
names through {{ packages }} instead of shebang $@.
Co-authored-by: Cursor <cursoragent@cursor.com>
just forwards a leading `--` into recipe args, which argparse rejects. Also resolve pchronicle to an absolute path so temp-cwd case bodies can find the binary. Co-authored-by: Cursor <cursoragent@cursor.com>
Seed cases from examples/data via PCHRONICLE_CASE_FIXTURES, update import and export syntax, skip serve/S3 without an explicit mode, and harden the just cases recipe against empty-args set -u failures on macOS bash. Co-authored-by: Cursor <cursoragent@cursor.com>
P05 was executed with placeholder credentials against catalog:// and failed. Treat catalog pins, placeholder AKs, and RustFS-only setup as MANUAL unless PCHRONICLE_CASE_MODE opts in. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
justfileentrypoints: dropgate/build-analysis/sanitizeand duplicate*-casesrecipes; keepdev,cases, andbuild-componentsas the canonical paths (macOS pVisor signing lives insidebuild-components).justrecipes for format/lint/test/build/smoke/cases, and add helpers (ci-nextest,build-agent-runtime,test-pchronicle-web, smoke CLIs, etc.).justfriction found in review:ci-nextestnow uses+packages+{{ packages }}(shebang$@is empty on the pinned just).just cases … -- …no longer forwards a literal--to argparse; empty-argset -uis safe on macOS bash.PCHRONICLE_CASE_FIXTURES, use current import/export CLI, and skip serve/S3/Catalog/RustFS unlessPCHRONICLE_CASE_MODEopts in.Test plan
just --summarylists the new CI helpers and no longer listsgate/test-*-cases*/build-analysis/sanitizeci-nextest, python, pvisor-cases, examples)just cases pchronicle→ S01–S04 PASS, S05–S06 MANUALjust cases pchronicle-cluster→ P01–P07 MANUAL (exit 0)just cases pvisor --case A01forwards case filters without argparse errors