Indicate relayed tunnels and fix a build problem - #393
Open
nbrownus wants to merge 2 commits into
Open
Conversation
jasikpark
reviewed
Jul 31, 2026
jasikpark
left a comment
Contributor
There was a problem hiding this comment.
Reviewed with most of the attention on the Dart↔Go contract, since none of the Go in this repo changes.
Verified:
- The JSON keys match nebula v1.11.0's
ControlHostInfotags exactly (currentRelaysToMe/currentRelaysThroughMe,[]netip.Addr→ string arrays), so the already-pinned version emits everything the model parses — no Go-side changes needed, as expected. isRelayedsemantics check out againstcopyHostInfo: relay IPs persist in relay state after a direct path exists, and a relayed tunnel'sCurrentRemoteis the zeroAddrPort, which marshals to""→nullon the Dart side. Gating oncurrentRemote == null && currentRelaysToMe.isNotEmptyis exactly right.
praise: the "has a relay but is also direct → not relayed" test pins the tricky quadrant of that truth table — nice.
One real issue inline (the flutter build ios --config-only call is cwd-dependent and pre-build actions don't run at the repo root); the rest are non-blocking nits.
— Caleb + Cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some basic relay information for tunnels using a relay
Also ran into a build issue from our ios target getting moved back to 13, this asserts we are at the correct version (14)