Skip to content

Indicate relayed tunnels and fix a build problem - #393

Open
nbrownus wants to merge 2 commits into
mainfrom
relay-indicator
Open

Indicate relayed tunnels and fix a build problem#393
nbrownus wants to merge 2 commits into
mainfrom
relay-indicator

Conversation

@nbrownus

Copy link
Copy Markdown
Contributor

Adds some basic relay information for tunnels using a relay

IMG_3963 IMG_3964

Also ran into a build issue from our ios target getting moved back to 13, this asserts we are at the correct version (14)

@jasikpark jasikpark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with most of the attention on the Dart↔Go contract, since none of the Go in this repo changes.

Verified:

  • The JSON keys match nebula v1.11.0's ControlHostInfo tags exactly (currentRelaysToMe/currentRelaysThroughMe, []netip.Addr → string arrays), so the already-pinned version emits everything the model parses — no Go-side changes needed, as expected.
  • isRelayed semantics check out against copyHostInfo: relay IPs persist in relay state after a direct path exists, and a relayed tunnel's CurrentRemote is the zero AddrPort, which marshals to ""null on the Dart side. Gating on currentRemote == null && currentRelaysToMe.isNotEmpty is exactly right.

praise: the "has a relay but is also direct → not relayed" test pins the tricky quadrant of that truth table — nice.

One real issue inline (the flutter build ios --config-only call is cwd-dependent and pre-build actions don't run at the repo root); the rest are non-blocking nits.

— Caleb + Cache

Comment thread ensure-mobile-nebula.sh Outdated
Comment thread ensure-mobile-nebula.sh
Comment thread nebula/go.mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants