Skip to content

按需安装引擎并统一模板与文件卡片适配 - #396

Merged
Devin-AXIS merged 1 commit into
mainfrom
codex/optional-engine-runtimes
Aug 22, 2026
Merged

按需安装引擎并统一模板与文件卡片适配#396
Devin-AXIS merged 1 commit into
mainfrom
codex/optional-engine-runtimes

Conversation

@Devin-AXIS

Copy link
Copy Markdown
Owner

结果

  • 将 Codex Harness、DeepSeek Harness 改为可检测、按需安装和卸载的独立引擎包,保留工作区与会话数据。
  • 在项目创建与设置中增加统一的引擎安装状态、启动过渡和引擎管理界面。
  • 统一多引擎模板内部上下文与文件输出卡片协议,移除公共 UI 文本猜测、旧卡片字段和无效自动打开路径。
  • 加强 Codex OAuth 刷新时机及过期状态提示,并补齐服务端文件解析与引擎适配测试。

验证

  • pnpm --filter @ipollowork/app typecheck
  • pnpm --filter ipollowork-server typecheck
  • App 全量测试:931 passed, 0 failed
  • 相关服务端测试:40 passed, 0 failed
  • git diff --check
  • 可维护性审计通过
  • Fraimz app-smoke 通过
  • Electron 开发版重建并实测 DeepSeek 模板标签、隐藏上下文和 Design 文件卡片打开

已知的基线测试差异

服务端全量测试为 533 passed / 3 skipped / 3 failed。失败项是两个已下架竖屏视频模板的目录断言,以及一个已经返回 sessionId 但测试仍按旧响应断言的用例;均不在本次改动路径。

@Devin-AXIS
Devin-AXIS merged commit 9dd98d9 into main Aug 22, 2026
2 of 6 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b14fd662a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +63 to +65
const candidates = app.isPackaged
? [path.join(process.resourcesPath, "server", "dist", "constants.json")]
: [path.resolve(__dirname, "../../..", "constants.json")];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve engine versions from inside the packaged ASAR

In every packaged desktop build, constants.json is staged under server/dist and included by the builder's files: server/**/*, so it lives inside app.asar, not at process.resourcesPath/server/dist/constants.json (only bundled templates are copied there as an extra resource). This lookup therefore fails and all engine versions become unknown; installation then requests assets such as ipollowork-engine-codex-harness-...-unknown.tar.gz, while the release workflow publishes versioned filenames, causing optional engine downloads to return 404. Add the packaged __dirname/../server/dist/constants.json location or copy the constants file into extraResources.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants