-
Notifications
You must be signed in to change notification settings - Fork 302
feat(cliprdr): add a Linux clipboard backend #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AKolenda
wants to merge
4
commits into
Devolutions:master
Choose a base branch
from
AKolenda:feat/cliprdr-native-linux
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,625
−5
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d57e221
feat(cliprdr): add a Wayland data-control clipboard client
glamberson 085bfee
feat(cliprdr-native): add a Linux clipboard backend
e6a0cc6
fix(cliprdr-native): render Linux clipboard data on demand
d826491
fix(cliprdr-native): keep production feature builds lint-clean
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,35 @@ | ||
| # IronRDP CLIPRDR native backends | ||
|
|
||
| Native CLIPRDR backend implementations. Currently only Windows is supported. | ||
| Native CLIPRDR backend implementations: Windows (`WinClipboard`) and Linux desktops over X11 and Wayland (`LinuxClipboard`, text and images). | ||
|
|
||
| This crate is part of the [IronRDP] project. | ||
|
|
||
| [IronRDP]: https://github.com/Devolutions/IronRDP | ||
|
|
||
| ## Linux | ||
|
|
||
| `LinuxClipboard` uses the shared `data_control` client for Wayland compositors offering `ext-data-control-v1` or `wlr-data-control-unstable-v1`. | ||
| When data-control is unavailable, including on GNOME, it falls back to X11/XWayland through XFixes and selection ownership. | ||
| A desktop without either clipboard service uses the client's stub backend. | ||
|
|
||
| Both backends react to selection changes and advertise remote formats without fetching their contents. | ||
| Text (`CF_UNICODETEXT`) and images (`CF_DIB`/`CF_DIBV5`, converted to/from PNG by `ironrdp-cliprdr-format`) are requested only when an application pastes. | ||
| Local clipboard content is read only when the peer requests it. | ||
| File clipboard transfer and HTML are not supported. | ||
|
|
||
| Only one Format Data Request is outstanding at a time, because responses do not identify their request. | ||
| A paste times out after five seconds, but its outstanding request is retained until the late response is drained. | ||
| If the peer never replies, new remote pastes fail until the clipboard channel is reinitialized; this prevents stale content from being mistaken for a newer copy. | ||
| Selection changes cancel older paste waiters, and the existing `ironrdp_cliprdr::loop_detector` detects content echoed by clipboard managers. | ||
|
|
||
| The clipboard workers bound data transfers and pending pastes. | ||
| X11 transfers use INCR for large content and separate requestor windows so late selection responses cannot complete newer reads. | ||
|
|
||
| State-machine tests run in the normal CI suite with `cargo test -p ironrdp-testsuite-core cliprdr_native`. | ||
| Three additional integration tests require a dedicated X11 display; the interoperability test also requires `xclip`: | ||
|
|
||
| ```sh | ||
| DISPLAY=:N cargo test -p ironrdp-testsuite-core cliprdr_native::linux::x11_ -- --ignored --test-threads=1 | ||
| ``` | ||
|
|
||
| Use a private display such as Xvfb for these tests, because they replace its clipboard selection. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.