Skip to content

Clean up types of numbers in the position interface #215

Description

@DominicOram

As someone using cs-web-lib in my app it's confusing that parameters that I would naturally expect to be numbers are expected to be passed in as strings e.g. many of the items in

export interface Position {
. See initial confusion at DiamondLightSource/atlas#84 (comment).

Acceptance Criteria

  • We can pass these values in as numbers
  • If we must keep backwards compatibility we still allow strings but ideally I feel like they should be typed as just numbers

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions