Skip to content

add use_scroll_spy() hook + TableOfContents comp - #283

Closed
sarendipitee wants to merge 4 commits into
DioxusLabs:mainfrom
sarendipitee:feat/table-of-contents
Closed

add use_scroll_spy() hook + TableOfContents comp#283
sarendipitee wants to merge 4 commits into
DioxusLabs:mainfrom
sarendipitee:feat/table-of-contents

Conversation

@sarendipitee

Copy link
Copy Markdown
Contributor
Screenshot 2026-05-30 at 2 02 47 AM

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

@sarendipitee
sarendipitee force-pushed the feat/table-of-contents branch from 77d8b5e to 90ac358 Compare June 8, 2026 19:53
@sarendipitee
sarendipitee force-pushed the feat/table-of-contents branch from 90ac358 to 7ea72b5 Compare June 11, 2026 05:30
@sarendipitee
sarendipitee force-pushed the feat/table-of-contents branch from 7ea72b5 to 303a3dc Compare June 11, 2026 05:42
@MentalGear

MentalGear commented Aug 29, 2026

Copy link
Copy Markdown

@ealmloff @ddudenin Thank you for these well made and a11y ready components, but I'm wondering why you don't reply on PRs that fix or add shadcn compliant features - is the repo still maintained or have you moved on ?

MentalGear pushed a commit to MentalGear/dioxus-components that referenced this pull request Aug 30, 2026
Ledger: focus-restore hook lift (dq lib.rs, 5af3cc2) and adapted
scroll_lock.rs (dq base + sarendipitee unlock-flash guard concept).

component-backlog.md: point-in-time harvest of new-component candidates
from the upstream PR queue, the fork network and Radix/shadcn catalog
gaps — component / where found / priority / effort-to-fit scored
against the definition-of-done loop, with recommendations (ComboboxMulti
first; split PR DioxusLabs#283 three ways; reject Schedule and Carousel; nested
submenu is fresh design work).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019MGZeXK5w53xbChgiWqN7a
@sarendipitee

Copy link
Copy Markdown
Contributor Author

@MentalGear I'd argue that the repo is dead and there's no interest from maintainers.

I've since moved on and have done a substantial amount of work in my fork of the repo and it's evolved greatly.

Which is unfortunate because I definitely attempted to contribute back to upstream so that everyone could benefit from my work and if anyone wanted to contribute back I'd benefit as well. But sadly that only works with active maintainers.

@ddudenin

ddudenin commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@ealmloff @ddudenin Thank you for these well made and a11y ready components, but I'm wondering why you don't reply on PRs that fix or add shadcn compliant features - is the repo still maintained or have you moved on ?

I really appreciate your appreciation of my status, but I am not the owner of this repository. All the changes I've made over time were made solely for the needs of my own project. I'm currently fully focused on it, and I have all the necessary tools. That's why I haven't been active here lately. So, essentially, I'm just as much of an enthusiast as you are :)

@ealmloff

ealmloff commented Sep 8, 2026

Copy link
Copy Markdown
Member

While this seems to work, there are a bunch of other unrelated changes in this diff and many conflicts. In general, I would like to be more careful about composability and the public api we expose for components. When I have talked with sarendipitee in the past, they said they were not interested in upstreaming work from their work anymore. If that is not the case and you would like to upstream piecemeal, feel free to reopen

@ealmloff ealmloff closed this Sep 8, 2026
@sarendipitee

sarendipitee commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

they said they were not interested in upstreaming work from their work anymore

Just for clarity for anyone else reading this... I lost interest in upstreaming work because nothing gets reviewed or merged in a timely manner not because I am simply just "not interested".

My fork of this repo is 300+ commits ahead.

I have spent nearly 100 hours and 1000s of dollars adding new features, fixing bugs, creating dozens of new components, and full E2E Playwright tests for every single component.

If maintainers want to adopt and integrate my contributions I have absolutely no problem with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants