Fixes dialog closing unexpectedly - #286
Open
pkleineb wants to merge 1 commit into
Open
Conversation
mroetsc
force-pushed
the
fix/dialog_closes_unexpectedly
branch
2 times, most recently
from
July 22, 2026 15:03
7457ed4 to
bf007c1
Compare
this switches from use_outside_dismiss javascript function to dioxus owned event stack
Member
|
Can you share a reproduction for the issues you were running into with the current implementation? I cannot get the dialog on the component demo to close when clicking on the dialog content on chrome, safari, or firefox. While this fix does work with the current way the component is laid out, we use this hook elsewhere where a similar fix is not applicable, so I would like to fix the general problem if we can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the newer versions of dioxus-primitives, dialogs would close when clicking on their internal content such as text and empty space. This PR aims to fix this by using the internal dioxus event implementation instead of javascript. Specifically I removed
use_outside_dismissin theDialogContentand replaced it with an onclick handler on theDialogRootbackdrop.If this implementation doesn't cover all of
use_outside_dismiss's features I'll be happy to add them.