Test tabs with dioxus test - #300
Open
hovinen wants to merge 16 commits into
Open
Conversation
This is intended as a starting point for porting more tests. It shows what one can already do with dixous-test. Since this depends on some changes to Dioxus and Blitz which have not yet been released (as of the time of writing), this adds dependency overrides to point to the current HEAD of the respective Git repositories.
This is intended as a starting point for porting more tests. It shows what one can already do with dixous-test. Since this depends on some changes to Dioxus and Blitz which have not yet been released (as of the time of writing), this adds dependency overrides to point to the current HEAD of the respective Git repositories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #289 and adds some tests of the tabs components using dioxus-test.
This includes a bunch of changes to update the components to the current Dioxus version, which was necessary to get the tests to compile. Once the dependent PRs in Blitz, Dioxus, and dioxus-test are merged, I'll split out a separate PR to do the necessary updates. For now, one may focus on the tests in tabs.rs.
This also fixes one bug which came up while writing tests: The content of the currently active tab was in a div with an attribue
hidden="false". This doesn't actually make the element visible according the spec. One must remove thehiddenattribute entirely to show the element.