Support restricting by_role queries by accessible name - #18
Merged
ealmloff merged 7 commits intoSep 4, 2026
Merged
Conversation
Previously, effects would not execute and cause re-rendering of the DOM after the initial render or after processing an event. As a result, a test would have to run ane extra `pump()` in some cases, expecially when an effect performed some kind of initialization which an event handler needs to run correctly. This is not the best developer experience. This adds some calls to both the initial render and the event handler so that effects are processed and the DOM re-rendered based on those. The tests then get a more stable state after each DOM interaction. This modifies two of the doctests to make the event handlers (which were claimed to be asynchronous but actually fall under the above rule) truly asynchronous.
Previously, tests would have to invoke `build()` on `DocumentTester` to trigger the initial DOM render before they could interact with the DOM. This is easy to forget and can lead to confusion. This makes the call to `build()` implicit and changes the method to be private. Tests can now interact with `DocumentTester` immediately after invoking `render()`.
This uses a new function `synthetic_form_event` in the dioxus-native-dom crate to generate the event data. It works analogously to the existing `click()` method.
This adds a method `having_name` to `QueryByRole` and makes that visible to library consumers. It implements the [W3C accessible name algorithm](https://w3c.github.io/aria/accname/#computation-steps) to obtain the accessible name. Thus this adds support for the equivalent of `getByRole(<role>, {name: "<name>"})` from Playwright. To do this, this introduces a new module `query::aria_tree` which implements a very rudimentary subset of the [W3C spec](https://w3c.github.io/aria/accname/#computation-steps) for accessible name. The implementation is limited by what the `build_accessibility_tree` method in Blitz can do. It already suffices for some basic use cases, though. I could not find another usable implementation of the W3C spec; otherwise I would have used that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a method
having_nametoQueryByRoleand makes that visible to library consumers. It implements theW3C accessible name algorithm to obtain the accessible name.
Thus this adds support for the equivalent of
getByRole(<role>, {name: "<name>"})from Playwright.To do this, this introduces a new module
query::aria_treewhich implements a very rudimentary subset of the W3C spec for accessible name. The implementation is limited by what thebuild_accessibility_treemethod in Blitz can do. It already suffices for some basic use cases, though.I could not find another usable implementation of the W3C spec; otherwise I would have used that.
This PR builds on top of #17.