fix(cli): make asset preloads deterministic and orderable - #5817
Open
Ddystopia wants to merge 1 commit into
Open
fix(cli): make asset preloads deterministic and orderable#5817Ddystopia wants to merge 1 commit into
Ddystopia wants to merge 1 commit into
Conversation
The manifest groups assets in hash sets, whose iteration order changes from run to run, so the generated index.html differed between builds of an unchanged app and defeated caching. `AppManifest::unique_assets` and `get_first_asset_for_source` now walk the manifest in an explicit order (bundled path, then source path). Preload tags also get two new knobs. `with_fetch_priority` sets the `fetchpriority` attribute of the generated `<link rel="preload">`, and `with_preload_order` places a tag among the other preloads. Every preload now flows through one ordered list that is rendered ahead of the rest of the head, so a resource the first render waits on can be discovered before the render blocking styles and scripts. Closes DioxusLabs#4439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest groups assets in hash sets, whose iteration order changes from run to run, so the generated index.html differed between builds of an unchanged app and defeated caching.
AppManifest::unique_assetsandget_first_asset_for_sourcenow walk the manifest in an explicit order (bundled path, then source path).Preload tags also get two new knobs.
with_fetch_prioritysets thefetchpriorityattribute of the generated<link rel="preload">, andwith_preload_orderplaces a tag among the other preloads. Every preload now flows through one ordered list that is rendered ahead of the rest of the head, so a resource the first render waits on can be discovered before the render blocking styles and scripts.Closes #4439