Allow web.pre_compress to select gzip - #5819
Open
Ddystopia wants to merge 1 commit into
Open
Conversation
Brotli is only negotiated over https[^1], so sites served over plain http got no benefit from pre-compression. `web.pre_compress` now accepts an algorithm name alongside the booleans: pre_compress = false # no pre-compression pre_compress = true # brotli, as before pre_compress = "brotli" pre_compress = "gzip" Pre-compressing a folder also drops the compressed files belonging to the algorithms that are not in use, so switching algorithms doesn't leave the previous build's output behind. Closes DioxusLabs#4434 [^1]: https://hacks.mozilla.org/2015/11/better-than-gzip-compression-with-brotli/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brotli is only negotiated over https1, so sites served over plain http got no benefit from pre-compression.
web.pre_compressnow accepts an algorithm name alongside the booleans:Pre-compressing a folder also drops the compressed files belonging to the algorithms that are not in use, so switching algorithms doesn't leave the previous build's output behind.
Closes #4434
Footnotes
https://hacks.mozilla.org/2015/11/better-than-gzip-compression-with-brotli/ ↩