Skip to content

Rename Vambe template to vambe-mail.com/email - #1677

Open
Rlopeze wants to merge 2 commits into
Domain-Connect:masterfrom
Rlopeze:rename-vambe-template
Open

Rename Vambe template to vambe-mail.com/email#1677
Rlopeze wants to merge 2 commits into
Domain-Connect:masterfrom
Rlopeze:rename-vambe-template

Conversation

@Rlopeze

@Rlopeze Rlopeze commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description

Renames the recently merged vambe.ai.email.json (#1671) to vambe-mail.com.email.json, moving the provider identity to Vambe's dedicated email-infrastructure domain. The old identity was never onboarded with any DNS provider yet, so nothing depends on it.

Vambe (vambe.ai) is an AI-powered customer communication platform (WhatsApp, Instagram, email and more) used by businesses across Latin America. The template connects a customer's domain for outbound email through Vambe: one TXT record for domain ownership verification and three CNAME records for email authentication (SPF return-path and two DKIM selectors, provisioned per-domain via Twilio SendGrid, hence the host/target variables).

Changes vs the merged file: providerIdvambe-mail.com, syncPubKeyDomaindomainconnect.vambe-mail.com, syncRedirectDomainvambeai.com,vambe-mail.com. Records are unchanged.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain — the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") — use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary — prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label — the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain — use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Justifications:

  • %spfHost% is a bare host variable (a SendGrid-generated return-path subdomain such as em1234). Its value is generated by Twilio SendGrid's domain authentication and passed by Vambe's backend in a signed request — it is never user-supplied. The record is a CNAME pointing to a SendGrid target, mirroring the already-published sendgrid.com.domain-auth template, which uses the same variable host shape for the same reason.
  • DKIM hosts fix the non-variable part (%dkim1Selector%._domainkey / %dkim2Selector%._domainkey); selectors are also SendGrid-generated (s1/s2).
  • essential: OnApply is not used: all four records are required for the service to function and none are user-managed records like DMARC.

Online Editor test results

Editor test link(s):

Test vambe-mail.com/email example.com/@

Test vambe-mail.com/email example.com/mail

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 2 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

@github-actions

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

Copy link
Copy Markdown

Linter OK

vambe-mail.com.email.json

Level Code Note
info DCTL1021 missing from iana definitions
info DCTL1031 all record groupId values are the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant