Rename Vambe template to vambe-mail.com/email - #1677
Open
Rlopeze wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PR Description Check PassedAll required sections are filled in correctly. Details |
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
…into rename-vambe-template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the recently merged
vambe.ai.email.json(#1671) tovambe-mail.com.email.json, moving the provider identity to Vambe's dedicated email-infrastructure domain. The old identity was never onboarded with any DNS provider yet, so nothing depends on it.Vambe (vambe.ai) is an AI-powered customer communication platform (WhatsApp, Instagram, email and more) used by businesses across Latin America. The template connects a customer's domain for outbound email through Vambe: one TXT record for domain ownership verification and three CNAME records for email authentication (SPF return-path and two DKIM selectors, provisioned per-domain via Twilio SendGrid, hence the host/target variables).
Changes vs the merged file:
providerId→vambe-mail.com,syncPubKeyDomain→domainconnect.vambe-mail.com,syncRedirectDomain→vambeai.com,vambe-mail.com. Records are unchanged.Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC)@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostlabel — the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PR descriptionhostfield to create a subdomain — use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC)Justifications:
%spfHost%is a bare host variable (a SendGrid-generated return-path subdomain such asem1234). Its value is generated by Twilio SendGrid's domain authentication and passed by Vambe's backend in a signed request — it is never user-supplied. The record is a CNAME pointing to a SendGrid target, mirroring the already-publishedsendgrid.com.domain-authtemplate, which uses the same variable host shape for the same reason.%dkim1Selector%._domainkey/%dkim2Selector%._domainkey); selectors are also SendGrid-generated (s1/s2).essential: OnApplyis not used: all four records are required for the service to function and none are user-managed records like DMARC.Online Editor test results
Editor test link(s):
Test vambe-mail.com/email example.com/@
Test vambe-mail.com/email example.com/mail
🤖 Generated with Claude Code