Skip to content

fix(do-7299): replace Docker image with composite+binary for ARM64 support - #1

Merged
jrbeilke merged 7 commits into
mainfrom
do-7299-arm64
Aug 19, 2026
Merged

fix(do-7299): replace Docker image with composite+binary for ARM64 support#1
jrbeilke merged 7 commits into
mainfrom
do-7299-arm64

Conversation

@jrbeilke

@jrbeilke jrbeilke commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

What

Replaces using: docker (single-arch AMD64 ghcr.io image) with using: composite that downloads the correct arch binary from GitHub Releases, supporting both x86_64 and aarch64.

Files changed

  • action.ymlcore change: swap Docker image for composite + arch-aware binary download
  • README.md — fork notice explaining this is a shim, not a true fork
  • .github/CODEOWNERS — DriveWealth org requirement (* @DriveWealth/devops)
  • .github/workflows/test-action.yml — new: runs action end-to-end on both ubuntu-latest (amd64) and runs-on/pool=small-arm64 (arm64) to confirm the binary works on both arches
  • .github/workflows/pull-requests.yml — skip integration-test when TOKEN_INTEGRATION_TESTS secret absent (fork-safe)
  • .github/workflows/codeql-analysis.yml — bump codeql-action@v1@v3 (v1 incompatible with current runners)
  • hack/run-lint.sh — fix dead install.goreleaser.com URL (see upstream PR #184)

Why

The upstream ghcr.io/mszostok/codeowners-validator:v0.7.2 image is AMD64-only and fails on ARM64 runners. v0.7.2 ships a Linux_arm64 binary on GitHub Releases — this shim uses that instead.

Pinned to v0.7.2 (not latest) to avoid the GitHub App token scope regression introduced in v0.7.3+ (upstream issue mszostok/codeowners-validator#143).

Issue #174 (macOS Killed: 9) does not apply — that is macOS Gatekeeper, our runners are Linux.
Issue #183 (install.sh unsupported platform) does not apply — that is the install.sh script; we download the tarball directly.

How to use in dw-github-workflows

After merging, replace both references in ci-validate-codeowners.yaml:

# Before
uses: mszostok/codeowners-validator@f555ba682ec613249e7e478a4e0bff3ba35dc79f # v0.7.2

# After (use the merge commit SHA)
uses: DriveWealth/codeowners-validator@<merge-sha>

Also remove the stale AMD64-only runs-on pin and comment on the codeowners job in ci-validate-codeowners.yaml and dwp-feature-branch.yaml.

References

Checklist

  • action.yml updated
  • Arch detection: x86_64x86_64, aarch64arm64
  • INPUT_* env vars set explicitly (composite actions don't auto-set them)
  • README fork notice added
  • CODEOWNERS added
  • CI fixed (broken upstream workflows)
  • End-to-end test on both amd64 and arm64 runners

DriveWealth CI added 3 commits August 18, 2026 17:12
…pport

The upstream action uses 'docker://ghcr.io/mszostok/codeowners-validator:v0.7.2'
which is a single-arch AMD64 image. v0.7.2 ships Linux arm64 binaries on GitHub
Releases, so switch to a composite action that downloads the correct arch binary.

Pinned to v0.7.2 to avoid the token scope regression introduced in v0.7.3+
(upstream issue #143).
Composite actions do not auto-set INPUT_* env vars the way Docker/JS actions do.
codeowners-validator reads config via ENVS_PREFIX=INPUT, so each input must be
explicitly exported with the INPUT_ prefix.
- codeql-analysis.yml: bump codeql-action v1 -> v3 (v1 incompatible with current runners)
- pull-requests.yml: skip integration-test when TOKEN_INTEGRATION_TESTS secret absent (fork-safe)
- hack/run-lint.sh: fix dead goreleaser.com linter install URL (see upstream PR #184)

None of these affect action.yml behaviour — Go source is unchanged.
@jrbeilke
jrbeilke requested a review from a team August 19, 2026 14:31
DriveWealth CI added 4 commits August 19, 2026 09:37
Runs the composite action end-to-end on both ubuntu-latest (amd64) and
runs-on/pool=small-arm64 (arm64) to confirm the binary download and
execution works on both architectures.

Uses 'checks: syntax,files' to avoid needing a GitHub token.
DriveWealth has org-level default CodeQL scanning — the upstream codeql-analysis.yml
(which uses the deprecated codeql-action@v1) is redundant and fails on current runners.
@jrbeilke
jrbeilke merged commit 144e04c into main Aug 19, 2026
2 checks passed
@jrbeilke
jrbeilke deleted the do-7299-arm64 branch August 19, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants