corpus: mirror rvt-rs #221 — walls, doors, windows recovered exactly; full-project surface is 8 fields - #4
Merged
Conversation
… full-project surface is 8 fields rvt-rs #221 (RE-21) selects standalone placed instances by two element-record fields (container ElementId at +0x32 unset, placement kind at +0x42 = placed) and reproduces Revit's exported id sets exactly: IFCWALL 360, IFCDOOR 132, IFCWINDOW 6, IFCCOLUMN 256. The full-project verdict widens to 8 surface fields / 5 excluded (was 5 / 8); the element-fixture verdict is 4 / 8 with those categories decoder_baseline there. Both rvt-rs observations replaced (hash d88897c6…); manifests rebuilt; index re-chained; validators pass.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_49d999e3-51c1-41f4-a7eb-850098208a23) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rvt-rs #221 (RE-21) selects standalone placed instances by two element-record
fields (container ElementId at +0x32 unset, placement kind at +0x42 = placed)
and reproduces Revit's exported id sets exactly: IFCWALL 360, IFCDOOR 132,
IFCWINDOW 6, IFCCOLUMN 256. The full-project verdict widens to 8 surface
fields / 5 excluded (was 5 / 8); the element-fixture verdict is 4 / 8 with
those categories decoder_baseline there. Both rvt-rs observations replaced
(hash d88897c6…); manifests rebuilt; index re-chained; validators pass.
Note
Low Risk
Corpus-only manifest, observation, and hash-chain updates; no application code changes, but verdict semantics and CI gate expectations shift for wall/door/window counts.
Overview
Updates the magnetar corpus to reflect rvt-rs #211: partition element-record instance selection now recovers IFCWALL (360), IFCDOOR (132), and IFCWINDOW (6) with exact Revit export ElementId sets, alongside the existing column recovery.
Both artifacts get refreshed
rvt-rsobservations (754 building elements with geometry, new observation hash) and rebuilt manifests, verdicts, andMANIFEST_INDEXchain hashes; status stays PASS.On g-2026-0002 (full-project bridge), walls/doors/windows move from
known_gaptoknown, entersemantic_surface, and drop out ofexcluded— the scored surface widens to 8 fields / 5 excluded (was 5 / 8). On g-2026-0001 (20 KB element fixture), those same categories becomedecoder_baselineso counts are not double-claimed against the slim sibling manifest.Unsupported-feature labels are renamed (e.g.
typed_door_window_discrimination_and_host_binding→door_window_host_wall_binding/revit_element_parameters_to_ifc_property_sets); property-set notes now reference 754RvtElementRecordGeometrysets.Reviewed by Cursor Bugbot for commit e5a09fe. Configure here.