Interface with new webAPI by MaxJohansen · Pull Request #24 · Dualog-students/Diplomatic

MaxJohansen · 2018-07-04T15:45:46Z

Changes 🎈

Signatures are now fetched from the web API instead of from local storage! I've deleted a LOT of leftover resources and code from the old implementation and fixed the failing tests.

Types of changes

What types of changes does your code introduce? Mark boxes that apply with an x.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist ✔️

Mark boxes that apply with an x. These can also be filled out after the pull request is created.

I have read the coding convention guidelines and my code follows these.
Unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

jonjohansen

Good but not 💯 🥇

jonjohansen · 2018-07-05T06:55:16Z

 using System.Linq;
 using Diplomatic.Utils;




unnecessary newline 👎

jonjohansen · 2018-07-05T06:56:23Z

+
    public partial class Templates : ContentPage
    {
-


Newline before new block?

jonjohansen · 2018-07-05T06:58:47Z

            }
-            var next = new TextFields();
-            next.BindingContext = new TextFieldViewModel((Template)e.SelectedItem);
+            var next = new TextFields


newliner 🥈

jonjohansen · 2018-07-05T06:59:22Z

+                string query = string.Join("&", queryParams.ToArray());
+                string final = "https://qri7p78aml.execute-api.eu-west-2.amazonaws.com/dev/" + template.Name.ToLower() + "?" + query;
+                var endpoint = new Uri(Uri.EscapeUriString(final));
+                var next = new Result


Newliner 🥉

jonjohansen · 2018-07-05T06:59:36Z

+                {
+                    BindingContext = new ResultViewModel(endpoint, Filename)
+                };
+                await Navigation.PushAsync(next);


🥉 Newliner

IsakSundeSingh · 2018-07-05T07:15:37Z

        [JsonIgnore]
        public string Value { get; set; }
+        [JsonIgnore]
+        virtual public bool IsValid => !string.IsNullOrEmpty(Value);


This shouldn't be virtual. 🥈

IsakSundeSingh · 2018-07-05T07:20:28Z

+        [JsonProperty("id")]
+        public string Id { get; set; }
+        public Uri ImageUri {
+            get {


Newlines bro 🥉

IsakSundeSingh · 2018-07-05T07:22:14Z

                string content = reader.ReadToEnd();
-                templates = JsonConvert.DeserializeObject<List<Template>>(content);
+                Dictionary<string, Template> rawTemplates = JsonConvert.DeserializeObject<Dictionary<string, Template>>(content);
+                foreach (KeyValuePair<string, Template> entry in rawTemplates)


Newline bro :4th_place_medal:

IsakSundeSingh · 2018-07-05T07:24:07Z

    {
-        public Template[] TemplateList { get; set; }
+        public Template[] Templates { get; set; }
        public TemplatePickerViewModel()


IsakSundeSingh · 2018-07-05T07:24:15Z

 namespace Diplomatic.ViewModels
 {
+    using Models;
    public class TextFieldViewModel


IsakSundeSingh · 2018-07-05T07:24:40Z

 namespace Diplomatic.Views
 {
+    using ViewModels;
    public partial class MainPage : ContentPage


Newline :11st_place_medal:

IsakSundeSingh · 2018-07-05T07:26:08Z

        }

-        void OnShow ( object sender, EventArgs e)
+        private void OnShow ( object sender, EventArgs e)


No space before first function parameter.

IsakSundeSingh · 2018-07-05T07:26:48Z

+            template.Signature = (Signature)e.SelectedItem;
            var queryParams = new List<string> { };
-            foreach (var field in template.Fields)
+            foreach (Field field in template.Fields)


Newline before this line

IsakSundeSingh · 2018-07-05T07:26:59Z

            }
-            var query = string.Join("&", queryParams.ToArray());
-            string final = "https://qri7p78aml.execute-api.eu-west-2.amazonaws.com/dev/" + template.TemplateName.ToLower() + "?" + query;
+            queryParams.Add($"signature={template.Signature.Id}");


And after the block <3

IsakSundeSingh · 2018-07-05T07:27:16Z

+            string query = string.Join("&", queryParams.ToArray());
+            string final = "https://qri7p78aml.execute-api.eu-west-2.amazonaws.com/dev/" + template.Name.ToLower() + "?" + query;
            var endpoint = new Uri(Uri.EscapeUriString(final));
            var next = new Result


This starts a block, so a newline before it.

Initializers aren't real blocks to me 👀

IsakSundeSingh · 2018-07-05T07:28:26Z

+                {
+                    BindingContext = new SignaturePickerViewModel(selectedTemplate)
+                };
+                await Navigation.PushAsync(next);


IsakSundeSingh · 2018-07-05T07:28:46Z

-            await Navigation.PushAsync(next);
+                Template template = ((TextFieldViewModel)BindingContext).SelectedTemplate;
+                var queryParams = new List<string> { };
+                foreach (Field field in template.Fields)


Newliner before and after ❤️

IsakSundeSingh · 2018-07-05T07:29:03Z

+                {
+                    BindingContext = new ResultViewModel(endpoint)
+                };
+                await Navigation.PushAsync(next);


Come on man... :22nd_place_medal:

IsakSundeSingh

Fix it

Interface for saving images has been added - Implemented on iOS - Permissions have been set for iOS Views: Result has gotten two buttons Save button now has an action, which should run a code-behind function for saving NOTE: the name of the image saved in the codebehind should be changed

It now works on android! Filename sent in is "Navn" for now. This needs to change

Images now have names (Only available on an ANDROID near you)! Also Stuff looks clean now

Resolved scaling issue (Might have to refactor this into a decent scale later) Aligned signatures to the left.

IsakSundeSingh added the review label Jul 4, 2018

MaxJohansen requested review from IsakSundeSingh, jonjohansen and vebjornhaugland and removed request for IsakSundeSingh July 4, 2018 15:45

MaxJohansen force-pushed the feature/signatures branch from 9909e76 to 0856613 Compare July 4, 2018 19:22

jonjohansen suggested changes Jul 5, 2018

View reviewed changes

IsakSundeSingh reviewed Jul 5, 2018

View reviewed changes

MaxJohansen force-pushed the feature/signatures branch from 0856613 to 1d445b0 Compare July 5, 2018 07:16

IsakSundeSingh reviewed Jul 5, 2018

View reviewed changes

IsakSundeSingh suggested changes Jul 5, 2018

View reviewed changes

MaxJohansen force-pushed the feature/signatures branch 4 times, most recently from 1e404fa to 9e52de4 Compare July 5, 2018 07:49

MaxJohansen and others added 3 commits July 5, 2018 09:50

Rewrite to use new webAPI

e188918

Clean up unused assets and fix tests

e8d9f59

jonjohansen added 2 commits July 5, 2018 09:55

Image save!

4551d4e

It now works on android! Filename sent in is "Navn" for now. This needs to change

Ground breaking new feature

d7bed33

Images now have names (Only available on an ANDROID near you)! Also Stuff looks clean now

MaxJohansen force-pushed the feature/signatures branch from 9e52de4 to d7bed33 Compare July 5, 2018 07:55

Fix signatures in view

2425d7c

Resolved scaling issue (Might have to refactor this into a decent scale later) Aligned signatures to the left.

jonjohansen force-pushed the feature/signatures branch from 72673d6 to 2425d7c Compare July 5, 2018 10:47

Uh oh!

Conversation

MaxJohansen commented Jul 4, 2018

Changes 🎈

Types of changes

Checklist ✔️

Uh oh!

jonjohansen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IsakSundeSingh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants