Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,13 @@ jobs:
PGHOST: localhost
PGPORT: '5432'
PGUSER: postgres
# Rails deprecations print regardless; this adds the Ruby-level ones.
# Rails deprecations print regardless (test.rb sets deprecation = :stderr);
# this adds the Ruby-level ones.
#
# It is also the off-switch for test/quiet_warnings.rb, which otherwise filters
# gem-origin Ruby warnings out of local runs -- ~650 lines a run, none of it from
# our own code. Setting this here keeps CI's record complete. Remove this and CI
# loses the Ruby-level warnings twice over.
RUBYOPT: '-W:deprecated'
# features/support/open_on_first_failure.rb pops the first failed page
# open via Capybara's save_and_open_page -> Launchy -> xdg-open. Useful at
Expand Down Expand Up @@ -181,8 +187,11 @@ jobs:
# Phase 3 cleared all five and the job stayed red on ten others. Phase 4
# stage B cleared those, and the 5.0 bundle has been green since.
#
# As of the end of Phase 4, both bundles run identically:
# As of the end of Phase 4, both bundles ran identically:
# 838 unit / 145 spec / 139 functional / 7 orphan / 154 cucumber, 0F/0E.
# CMS-434 then removed the Forms subsystem and its tests. Do not treat the
# numbers above as the current expectation -- `script/test-summary` prints
# every group's summary in one place if you need today's.
#
# KEEP THIS JOB GATING. Three of the four root causes behind those ten
# failures were NOT Rails 5 incompatibilities. They were live defects on
Expand All @@ -199,6 +208,10 @@ jobs:
# never render, and an attribute chain that answers nil where it should
# raise. Every one fails identically on 4.2.
#
# (The two Forms defects were closed by CMS-434, which removed the subsystem
# rather than repairing it -- unused in production, unreachable from the admin
# UI. The argument above is unaffected: they were still found this way.)
#
# So this is not a Rails 5 canary. It is a second execution of the suite
# under different framework semantics, and it has found more 4.2 bugs than
# 5.0 ones. That is the argument for keeping it gating now that it passes.
Expand Down
6 changes: 6 additions & 0 deletions .simplecov
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# Every test entry point (test/test_helper.rb, spec/minitest_helper.rb,
# features/support/env.rb) requires simplecov first, which loads this file, so this is
# the one place shared by all five suites. See test/quiet_warnings.rb for what it does
# and how to turn it off.
require_relative 'test/quiet_warnings'

# The suite runs as five separate processes (units, spec, functionals, orphans,
# features) that merge through coverage/.resultset.json. SimpleCov discards any stored
# result older than merge_timeout, which defaults to 600s -- so on a full run,
Expand Down
20 changes: 11 additions & 9 deletions RAILS_UPGRADE_TEST_PRIORITY.md

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion app/assets/javascripts/cms/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
//= require cms/core_library
//= require cms/content_types
//= require cms/attachment_manager
//= require cms/form_builder
//= require cms/sitemap
//= require bootstrap
//= require bcms/ckeditor
Expand Down
250 changes: 0 additions & 250 deletions app/assets/javascripts/cms/form_builder.js

This file was deleted.

3 changes: 0 additions & 3 deletions app/assets/stylesheets/cms/default-forms.scss

This file was deleted.

Loading
Loading