fix(migration): purge global db binary logs#82
Open
mrrobot47 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a one-time container migration that disables EasyEngine’s default global MariaDB binlog configuration, safely purges only the default-named binlog files, and coordinates a retry-safe global-db restart when required—addressing persistent volumes on existing installs.
Changes:
- Introduces a new migration to detect the default binlog basename and (when safe) run
RESET MASTERbefore cleanup. - Removes EasyEngine’s default binlog directives from persisted
mariadb/conf/conf.d/ee.cnfand copies the updated config into the running container when possible. - Deletes only default-named
mariadb-bin.NNNNNNandmariadb-bin.indexfiles and uses a restart marker to safely complete restarts after partial failures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RESET MASTERfor the running global DB when the default binlog is active.ee.cnf.global-dbwith a retry-safe restart marker.mariadb-bin.NNNNNNandmariadb-bin.indexfiles.Why
The MariaDB image previously enabled binlogs by default for the global DB even though EasyEngine does not manage replication. Existing installs keep both config and logs in persistent volumes, so an image-only fix does not clean up affected installs.
Safety
mariadb-bin*files.RESET MASTERand file deletion are intentionally irreversible.Release Notes
This PR must be released with:
easyengine/service-commandincomposer.json/composer.lock.easyengine/mariadbinimg-versions.json.