Skip to content

Adds support for setting cache_dir via an environment variable #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdeelH merged 1 commit into from
Feb 4, 2026
Merged

Adds support for setting cache_dir via an environment variable #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/natural_language_geocoding/geocode_index/hierachical_place_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
from e84_geoai_common.util import timed_function

from natural_language_geocoding.geocode_index.geoplace import GeoPlaceType, Hierarchy
from natural_language_geocoding.geocode_index.index import GEOPLACE_INDEX_NAME, GeoPlaceIndexField
from natural_language_geocoding.geocode_index.index import (
GEOCODE_INDEX_CACHE_DIR,
GEOPLACE_INDEX_NAME,
GeoPlaceIndexField,
)
from natural_language_geocoding.geocode_index.opensearch_utils import (
QueryDSL,
create_opensearch_client,
Expand Down Expand Up @@ -236,9 +240,12 @@ class PlaceCache:

_cache_file: Path

def __init__(self, *, cache_dir: str | Path = "./temp", force_reload: bool = False) -> None:
def __init__(
self, *, cache_dir: str | Path | None = None, force_reload: bool = False
) -> None:
# Increment the name of the file when something changes about the format of the storage
self._cache_file = Path(cache_dir) / "hierarchical_place_cache_v2.json"
resolved_cache_dir = cache_dir or GEOCODE_INDEX_CACHE_DIR
self._cache_file = Path(resolved_cache_dir) / "hierarchical_place_cache_v2.json"
if force_reload or not self._cache_file.exists():
self._dicts = _populate()
self._cache_file.parent.mkdir(exist_ok=True)
Expand Down
2 changes: 2 additions & 0 deletions src/natural_language_geocoding/geocode_index/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import json
import logging
import os
import subprocess
from abc import ABC, abstractmethod
from collections.abc import Iterable
Expand Down Expand Up @@ -187,6 +188,7 @@ class GeoPlaceDoc(TypedDict):


GEOPLACE_INDEX_NAME = "geoplaces"
GEOCODE_INDEX_CACHE_DIR = os.getenv("GEOCODE_INDEX_CACHE_DIR", "./temp")

# The set of geo place types for which we'll index geometry spatially.
# We don't do this for all types due to some issues getting everything to index. In the future, we
Expand Down
Loading