Add a max-proxies parameter to EpixStartSnowflake - #1
Merged
Conversation
A single Snowflake proxy is often slow and drops out, which made the Tor bootstrap through it unreliable. The client library supports collecting several proxies and load-balancing across them (Tor's own client example uses -max 3), but the wrapper hard-coded Max: 1. Add a `max` argument to EpixStartSnowflake so the caller sets the count. Values below 1 default to 3 and the count caps at 8, so a bad config value cannot ask the broker for an unreasonable number of proxies. This changes the C ABI (one extra int argument), so callers must be rebuilt against the new header.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
EpixStartSnowflakehard-codedMax: 1, so the client only ever rendezvoused with a single Snowflake proxy. A single volunteer proxy is often slow and drops out, which made the Tor bootstrap through it unreliable.This adds a
maxargument (the number of simultaneous proxies to collect and load-balance across). Values below 1 default to 3 (Tor's own client example uses-max 3); the count caps at 8.ABI note
This adds one trailing
intargument toEpixStartSnowflake, so the C ABI changes. EpixNet'siptproxy-sysis updated to match and theiptproxy.revpin will move to the release built from this branch.Testing
Built the macOS
c-archivelocally with this change and ran an EpixNet node against it withIPTPROXY_LIB_DIR. The node collects multiple proxies instead of one.