feat(ui): hide Helm release secrets by default, with toggle - #19
Merged
Conversation
Helm 3 stores release state as Secrets (type helm.sh/release.v1, names sh.helm.release.v1.<release>.v<n>). These dominate the Secrets list and are rarely what an operator wants to see. - Hidden by default at the projection layer (Secrets view only). - Toggle per-context-tab with `H` (Action::ToggleHelmSecrets, remappable) or `:helm`; `:helm show` / `:helm hide` set state explicitly. - The Secrets table title advertises current state and the toggle key, so the hidden rows are never a surprise. Detection lives in ResourceEntity::is_helm_release() (matches the helm type column or the sh.helm.release.v1. name prefix), keeping the projector clean. Tests: model detection (type/name/negative/non-secret), projector hide-by- default + show-on-request, and a render+toggle integration test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helm 3 stores release state as Secrets (
type: helm.sh/release.v1, namessh.helm.release.v1.<release>.v<n>). They dominate the Secrets list and are rarely what an operator is looking for. This hides them by default and adds a toggle.H(Action::ToggleHelmSecrets, remappable via keymap.toml) or:helm.:helm show/:helm hideset the state explicitly.helm hidden (H show)/helm shown (H hide)), so the filtered rows are never surprising.Design
Detection lives in
ResourceEntity::is_helm_release()(matches the helm type column or thesh.helm.release.v1.name prefix), so the projector filter stays a one-liner. The flag is a per-tabshow_helm_secrets: boolthreaded throughViewRequest.Testing
make validategreen locally (99 tests + release build)🤖 Generated with Claude Code