feat(ui): previous-instance logs toggle (P) - #22
Merged
Conversation
In the logs pane, `P` (shift+p) toggles between the current and the previous (terminated) container instance's logs — `kubectl logs -p`, for debugging crashlooping containers. Closes gap #2 from the k9s parity audit (4.7). - One-shot fetch: previous logs don't follow and don't auto-reconnect (the container is gone), so the reconnect loop is skipped while previous is active. - Refetches on toggle (clears the buffer); a fresh log view always starts on the current instance. - Status line shows `instance:current|previous`. The PodLogRequest.previous plumbing already existed; this wires the UI to it. Test: toggle flips the flag, resets the buffer, and the title reflects the instance. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes gap #2 from the k9s parity audit (4.7): previous logs.
In the logs pane,
P(shift+p) toggles between the current and the previous (terminated) container instance's logs — equivalent tokubectl logs -p, for debugging crashlooping containers.instance:current/instance:previous.The
PodLogRequest.previousplumbing already existed (it flows toLogParams { previous, .. }); this PR wires the UI toggle to it and handles the follow/reconnect/tail semantics.Testing
make validategreen (102 tests + release build)🤖 Generated with Claude Code