refactor(ui): title/header/sort consistency + graduated right-sizing colors - #25
Merged
Conversation
Naming-convention consistency pass across the whole UI. Panel/overlay titles → one convention: `[TAG] subject (count) · meta… · hints…` - single `·` separator everywhere (drop `|` and `(parenthetical, lists)`) - full-word uppercase tags: table uses the kind ([PODS]/[DEPLOYMENTS]/…), plus [DRILL] [XRAY] [TRIAGE] [TEXT] [CONTEXTS] [CONTAINERS] [SOURCES] [LOGS] [DESCRIBE]/[DECODE]/[EVENTS] [PULSE] - counts in (n); meta as lowercase `key: value`; hints lowercase, `esc close` last - dropped the now-unused `title` field from the Contexts/LogSources overlays Column headers → one casing rule across every table (main, pods, per-kind, triage, events pane, overlays, :dump export): plain words use Title case (Namespace, Node, Ready, Restarts, Reason), acronyms stay uppercase (CPU, MEM, IP), formula columns kept as-is (%CPU/R). Fixes NODE→Node, RST→Restarts, the ALL-CAPS per-kind columns, the triage and events headers (CNT→Count), and the lowercase dump export. Sort: `s` now advances in left-to-right table-column order (Namespace→Name→Status→Age→Namespace) instead of an arbitrary jump. Tests updated for the new title/header strings; added a cycle_sort order test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The %R/%L pod columns each used a single color — %R only ever went yellow (never red, even at 400% of request), and %L jumped straight to red at ≥90% with no "approaching" warning. Make both a green→yellow→red gradient: - %CPU/R, %MEM/R (vs request): ok <100 · yellow ≥100 (under-requested) · red ≥200 (severely under-requested — QoS/scheduling risk) - %CPU/L, %MEM/L (vs limit): ok <75 · yellow ≥75 (approaching) · red ≥90 (throttle/OOM risk) Test: pod_usage_cells severity thresholds for both columns. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Capture the decision to defer the low-%R (over-provisioned) coloring until we track per-pod usage history (p95/max); a snapshot-based waste flag would false-alarm on momentary idle dips. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A UI consistency pass (mostly from close review), plus richer right-sizing coloring.
Naming convention harmony
[TAG] subject (count) · meta… · hints…— one·separator everywhere (no more|or(parenthetical, lists)), full-word uppercase tags ([PODS][XRAY][TRIAGE][CONTEXTS][LOGS][DESCRIBE]…), counts in(n),esc closelast.:dump): plain words → Title case (Namespace,Node,Ready,Restarts), acronyms → uppercase (CPU,MEM,IP), formulas as-is (%CPU/R). FixedNODE,RST, the ALL-CAPS per-kind columns, the triage/events headers (CNT→Count), and the lowercase dump export.sadvances in left-to-right column order (Namespace→Name→Status→Age→Namespace) instead of jumping.Graduated right-sizing colors
The
%R/%Lpod columns each used a single color. Now green→yellow→red:%R(vs request)%L(vs limit)Testing
make validategreen (108 tests + release build)pod_usage_cellsthresholds; existing title/header tests updated🤖 Generated with Claude Code