Connect Mapper to Map Hub with passkeys - #3
Draft
EthanOConnor wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds Mapper’s primary passkey connection flow for Map Hub. Mapper starts a one-time device authorization request, opens the Map Hub confirmation page in the browser, polls for approval, and stores the returned bearer token in the existing secure credential store.
The flow is available in first-use setup and connected-account settings. The saved origin-scoped token now authenticates Map Hub APIs and protected imagery tiles, so imported Map Hub OIC imagery does not need a separate token configuration.
Why
Manual token entry left Mapper unable to load authenticated Map Hub imagery and made account connection unnecessarily fragile. The browser confirmation uses the account’s normal sign-in path, including passkeys.
Dependency
Requires the matching Map Hub server branch
topic/mapper-passkey-connection, which supplies the browser/device authorization endpoints.Validation
ctest --test-dir build/dev-macos --output-on-failure -R '^(map_hub_workspace_t|oic_catalog_t)$'./scripts/check.sh(511 tests passed)