feat(providers): seed direct MiniMax default model and shortlist - #235
Open
octo-patch wants to merge 1 commit into
Open
feat(providers): seed direct MiniMax default model and shortlist#235octo-patch wants to merge 1 commit into
octo-patch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: The direct MiniMax provider preset had no default model and no curated model shortlist, unlike every other seeded direct provider.
What changed
raven/providers/registry.py: set the directminimaxprovider'sdefault_modeltominimax/MiniMax-M3, so non-interactive onboarding has a built-in fallback like the other seeded direct providers.raven/providers/common_models.py: add a curatedminimaxshortlist withminimax/MiniMax-M3andminimax/MiniMax-M2.7, so the model picker offers a default set out of the box.tests/test_provider_catalog.py: includeminimaxin the seeded-direct-provider set so the "default_model must be in the shortlist" invariant is enforced for it.Checks
uv run pytest tests/test_provider_catalog.py— 14 passeduv run pytest tests/test_cli_provider_commands.py tests/test_cli_onboard_commands.py tests/test_tui_rpc_setup.py— 116 passeduv run ruff check raven/providers/registry.py raven/providers/common_models.py tests/test_provider_catalog.py— clean