fix(visualize): include 1:1 backends and avoid null shared crash - #60
Merged
Conversation
Empty shared marshaled as null broke the HTML/canvas dashboard; include all referenced backends (including 1:1) in the usage ranking instead of only multi-product shares. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Topology HTML/canvas crashed when no backends were shared across products (
shared: null→.mapthrew), leaving the dashboard looking empty aside from products. Also include 1:1 product→backend usages in the ranking so tenants like Integratel show backend usage.Type of change
RHCL checklist
go test ./...ormvn test/npm test)-DskipTestswithout justificationTest plan
go test ./internal/visualize/ -count=1TestBuildTopologyDataEmptySharedMarshalsAsArray—sharedmarshals as[]TestBuildTopologyDataIncludesOneToOneBackends—billing_apicount 1 appears; multi-share ranks firsttopology.html— backend usage list non-empty with 1:1 backendsAdditional information
Made with Cursor