[pull] master from beyond-all-reason:master - #177
Merged
Conversation
Fixes captured ruins buildings being impossible to upgrade due to our lock-and-key yardmap hack requiring both the upgraded and upgradee buildings to snap together. Spawned ruins are all buildings so now are snapped to a grid based on their size. Odd-sized buildings (like 5x5 geos) use the odd grid (8-elmo offset) in snap. Even sided buildings (like mex) use the even grid (0 elmo offset).
### Work done The engine's `UnitIdle` fires only when a command queue drains through `FinishCommand` or an explicit Stop, so it misses many of the ways a unit can run out of work and never fires for any unit that never had a command. This adds `UnitIdlePost`, a custom callin that reads the unit's queue directly and once post-frame, reporting only those whose idle state actually changed. The "idle tasks" a unit gives itself are not "work tasks", so units with only those tasks in their command queue count as idle. The new callin is only in synced code. The new idle module, unit_idle_states, is in the shared modules folder so can be used in widgets later. The synthetic callins code gets a new per-frame view, the transition view, which only fires when states change rather than acting like a plain mark, so would ignore A->B->A for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )