Update README.md to enhance bot setup instructions - #34
Merged
Conversation
skywinder
commented
Sep 10, 2025
skywinder
commented
Contributor
- Revised database setup command to simplify usage.
- Added detailed instructions for running the bot from the local directory, including options for building and running the release version and using Nix.
- Improved clarity and organization of the bot setup section for better user experience.
- Revised database setup command to simplify usage. - Added detailed instructions for running the bot from the local directory, including options for building and running the release version and using Nix. - Improved clarity and organization of the bot setup section for better user experience.
cofob
approved these changes
Sep 10, 2025
… lease retrieval - Introduced a new rule file for documenting Mikrotik REST API usage and fallback mechanisms. - Enhanced the `get_leases` function to attempt HTTPS requests first, with automatic fallback to HTTP if HTTPS fails. - Improved error handling and logging for network and HTTP status errors during lease retrieval. - Updated the Mikrotik request logic to maintain legacy behavior while ensuring robust connectivity options.
Contributor
Author
one more feature in last commit
|
skywinder
force-pushed
the
fix-readme-and-status
branch
from
September 11, 2025 19:08
4c88027 to
c925c07
Compare
cofob
requested changes
Sep 13, 2025
| msg: Message, | ||
| state: Arc<RwLock<State>>, | ||
| ) -> Result<()> { | ||
| // Log on-demand debug info and trigger an immediate Mikrotik check in background |
Contributor
There was a problem hiding this comment.
Осталось для дебага? Можно удалить?
Contributor
Author
There was a problem hiding this comment.
да, делал чтоб понять что происходит, пость остануться логи инфо/ - почему нет?
| } | ||
|
|
||
| // Try HTTPS first, then fall back to HTTP (some RouterOS setups disable HTTPS) | ||
| let leases_https = attempt(reqwest_client, conf, "https").await; |
Contributor
There was a problem hiding this comment.
Можно просто добавить в конфиг возможность выбора http/https и всё
Contributor
Author
There was a problem hiding this comment.
кажтеся усложнение немного, но добавил конфиг для выбора. давай мержить!
- Added sections for linting and code quality, detailing commands for checking linting rules and running tests. - Included instructions for code formatting across multiple languages. - Provided guidance on regenerating the database schema after migrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.