Skip to content

Update documentation - #7151

Open
BlackYps wants to merge 3 commits into
developfrom
update-readme
Open

Update documentation#7151
BlackYps wants to merge 3 commits into
developfrom
update-readme

Conversation

@BlackYps

@BlackYps BlackYps commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Description of the proposed changes

I got rid of the duplicate documentation documents to move towards the goal of always having just a single source of truth. I merged the info of both documents and updated it where it was outdated.

Testing done on the proposed changes

Not applicable

Additional context

Checklist

Summary by CodeRabbit

Summary by CodeRabbit

  • Documentation
    • Removed/emptied internal contributor and deployment documentation files under .github
    • Migrated the changelog and contributor documentation to externally hosted pages
    • Updated README documentation links (including a new changelog subsection)
    • Refreshed deployment guidance by clarifying deploy branch origins and documenting related automatic database deployment updates

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 327486e2-e1dc-4413-8cb4-2366ab3eb20c

📥 Commits

Reviewing files that changed from the base of the PR and between a4d8322 and 15d0bf9.

📒 Files selected for processing (1)
  • docs/deployment.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/deployment.md

📝 Walkthrough

Walkthrough

Three .github/ documentation files are removed. README links now point to published documentation, and docs/deployment.md updates deployment branch descriptions and adds related unit database deployment workflow links.

Changes

Documentation migration to published site

Layer / File(s) Summary
README link updates to published docs
README.md, README-russian.md
README.md adds a Changelog subsection and replaces local .github/* links; README-russian.md updates its changelog link to the published site.
Deployment documentation updates
docs/deployment.md, .github/CHANGELOG.md, .github/DEPLOYMENT.md, .github/DEVELOPMENT.md
Deployment branch descriptions are reworded, related deployment workflows are documented, and the three .github/ documentation files are removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested labels: area: changelog management, area: documentation

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is concise but too generic to clearly identify the main change. Use a more specific title like 'Consolidate documentation into a single source of truth'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description follows the template and clearly explains the changes, testing, and context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-readme

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot marked this pull request as draft June 21, 2026 23:08

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
README.md (1)

15-25: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Use descriptive link text instead of "here".

Line 17 uses the generic link text [here], which is flagged by the linter (MD059). Consider using a more descriptive anchor like [complete changelog] or similar.

-You can find the complete changelog [here](https://faforever.github.io/fa/changelog).
+You can find the [complete changelog](https://faforever.github.io/fa/changelog).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` around lines 15 - 25, The link text "here" in the Changelog
section uses generic anchor text which violates the MD059 linting rule and
reduces accessibility. Replace the generic link text "here" with more
descriptive text that clearly indicates what the link points to, such as
"complete changelog", ensuring the new text accurately describes the destination
of the link while maintaining the same URL reference.

Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/deployment.md`:
- Around line 127-129: The relative file paths in the "Related deployments"
section for the three workflow links (Unit DB, Spooky DB, and ETFreeman DB) are
incorrect and will not resolve properly. Update all three links by replacing the
incorrect `./workflows/` paths with the correct relative path
`../.github/workflows/`. Additionally, fix the double slash syntax error in the
Unit DB link (currently `./workflows//unitdb-update.yaml`) by correcting it to
use the proper path format. This will ensure the links correctly point to the
workflows directory located at `.github/workflows/` from the
`docs/deployment.md` file.

---

Nitpick comments:
In `@README.md`:
- Around line 15-25: The link text "here" in the Changelog section uses generic
anchor text which violates the MD059 linting rule and reduces accessibility.
Replace the generic link text "here" with more descriptive text that clearly
indicates what the link points to, such as "complete changelog", ensuring the
new text accurately describes the destination of the link while maintaining the
same URL reference.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5a9cad5-e6be-4dcb-903e-557faf8df22c

📥 Commits

Reviewing files that changed from the base of the PR and between c80d63c and a4d8322.

📒 Files selected for processing (6)
  • .github/CHANGELOG.md
  • .github/DEPLOYMENT.md
  • .github/DEVELOPMENT.md
  • README-russian.md
  • README.md
  • docs/deployment.md
💤 Files with no reviewable changes (3)
  • .github/DEVELOPMENT.md
  • .github/DEPLOYMENT.md
  • .github/CHANGELOG.md

Comment thread docs/deployment.md Outdated
@BlackYps
BlackYps marked this pull request as ready for review July 27, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant