Added IP-detection, proxy adding, api-key, docker-compose, better doc… - #27
Closed
mindflowgo wants to merge 1 commit into
Closed
Added IP-detection, proxy adding, api-key, docker-compose, better doc…#27mindflowgo wants to merge 1 commit into
mindflowgo wants to merge 1 commit into
Conversation
Owner
|
not needed, close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No substantial changes, but I found the project confusing initially and had to spend time exploring it. Thus the docker-compose, the documentation additions (markdown) helped me set my bearing.
I also made it output in the docker logs and provide the IP, and allow optional proxy (so if running from a server, you can provide a residential IP for the requests).
You can also lock API calls with an auth-token if it's public facing.
Nothing earth shattering, the code looks great, but these are small improvements to make it easier for a new user to orient themselves. (In my opinion at least).