fix(tasktypeedit): move the icon renderer off the bare fa prefix - #26
Merged
Conversation
The icon column composes its class as `fa fa-` + the stored taskTypes.ttIcon value. `fa` is still the solid alias in Font Awesome 7 so this rendered, but it is the last call site in this repo left on the old prefix after the FA7 port, and it evades the icon-name check because the name is concatenated on -- the literal ends at the quote, so nothing matches it. No data change here. The values it renders are the taskTypes rows repaired by FOGProject/fogproject#1338, which corrects the seven FA4 outline names FA7 dropped. Co-Authored-By: Claude <noreply@anthropic.com>
mastacontrola
added a commit
to FOGProject/fogproject
that referenced
this pull request
Aug 24, 2026
Carries FOGProject/fog-plugins#26, which moves the tasktypeedit icon renderer off the bare `fa` prefix -- the plugin half of the same cleanup this PR makes in core. Verified by fetching the release into the tree: stamp reads v1.6.16 and the renderer in the installed copy emits `fas fa-`. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The icon column composes its class as
fa fa-+ the storedtaskTypes.ttIconvalue:fais still the solid alias in FA7 so this renders, but it is the last call site in this repo left on the old prefix after the FA7 port — and it evades the icon-name check, because the name is concatenated on so the literal ends at the quote and matches nothing.No data change here. The values it renders are the
taskTypesrows repaired by FOGProject/fogproject#1338, which corrects the seven FA4 outline names FA7 dropped (plus-square-o,hdd-o,arrow-circle-o-down,arrow-circle-o-up,hourglass-o,flag-o, andbookmark-ointaskStates).